Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for directly imported wc-range-datepicker files #115

Open
jordanjones243 opened this issue Apr 3, 2023 · 2 comments
Open

Write tests for directly imported wc-range-datepicker files #115

jordanjones243 opened this issue Apr 3, 2023 · 2 comments

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Apr 3, 2023

General Support Request

Support request

With the recent refactor of auro-datepicker and adding the new date range feature, we need to write tests to cover the vendor files from wc-range-datepicker.

Possible Solution

Write the needed tests for those vendor files.

Context

When reviewing the code coverage for auro-datepicker, the data shows that almost none of those vendor files from wc-range-datepicker are being tested, bringing the overall code coverage of the component way down.

AC

These tests will be written once the new version of auro-datepicker is released.

@jordanjones243 jordanjones243 added auro-datepicker not-reviewed Issue has not been reviewed by Auro team members labels Apr 3, 2023
@blackfalcon blackfalcon removed their assignment Apr 5, 2023
@blackfalcon blackfalcon added Type: Testing and removed not-reviewed Issue has not been reviewed by Auro team members labels Apr 5, 2023
@blackfalcon
Copy link
Member

@jordanjones243 this is a weird situation. The code in the vendor dir is not specifically our code and I would not expect this team to write tests for vendor code.

For this initial release, I would think it's best to ignore the vendor dir. Moving forward we will be reviewing options for owning this code as either directly in this repo or creating a better dependency.

Exit criteria

Update test expectations that allow for ignoring all the code in the vendor dir.

@blackfalcon
Copy link
Member

Moved this last issue from the date range selection feature milestone to the new datepicker mobile experience milestone as there is no reason to NOT do this work.

@settings settings bot removed the Type: Testing label Jan 4, 2024
@blackfalcon blackfalcon added Type: Perf Performance update to existing code Type: tech-debt labels May 13, 2024
@jason-capsule42 jason-capsule42 removed the Type: Perf Performance update to existing code label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants