Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM update @web/test-runner causes tests to fail #183

Open
blackfalcon opened this issue Jan 7, 2024 · 0 comments
Open

NPM update @web/test-runner causes tests to fail #183

blackfalcon opened this issue Jan 7, 2024 · 0 comments
Assignees

Comments

@blackfalcon
Copy link
Member

General Support Request

When updating @web/test-runner 0.15.3 ❯ 0.18.0

 Non-Semver Versions less than 1.0.0, caution.
❯◯ @web/dev-server devDep   0.1.38  ❯  0.4.1   https://github.com/modernweb-dev/web/tree/master/packages/dev-server
 ◯ @web/test-runner devDep  0.15.3  ❯  0.18.0  https://github.com/modernweb-dev/web/tree/master/packages/test-runner

See the following error in the stack trace

test/auro-datepicker.test.js:

 🚧 Browser logs:
      Lit is in dev mode. Not recommended for production! See https://lit.dev/msg/dev-mode for more information.
      Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information.
      Element auro-dropdown scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
      Element auro-input scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
      Element auro-calendar scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
      Element auro-calendar-month scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
      Element auro-calendar-cell scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.
      Element auro-datepicker scheduled an update (generally because a property was set) after an update completed, causing a new update to be scheduled. This is inefficient and should be avoided unless the next update can only be scheduled as a side effect of the previous update. See https://lit.dev/msg/change-in-update for more information.

 ❌ auro-datepicker > handles the required state being set
      AssertionError: expected null to equal 'valueMissing'
        at n.<anonymous> (test/auro-datepicker.test.js:80:53)

Chrome: |██████████████████████████████| 1/1 test files | 36 passed, 1 failed

Code coverage: 77.27 %
View full coverage report at coverage/lcov-report/index.html

Finished running tests in 13s with 1 failed tests.

ERROR: "test" exited with 1.

This is also curious

Multiple versions of Lit loaded.

Noticed that these dependencies were not updated with the last feature release.

"@web/dev-server": "^0.1.38",
"@web/test-runner": "^0.15.3",

Possible Solution

Review differences between versions 0.15.3 ❯ 0.18.0 and update tests as needed.

Additional context

Was able to determine that there is an issue starting from version 0.16.1

test/auro-datepicker.test.js:

 ❌ auro-datepicker > handles the required state being set
      AssertionError: expected null to equal 'valueMissing'
        at n.<anonymous> (test/auro-datepicker.test.js:80:53)

There doesn't seem to be any issues with @web/dev-server but not fully determined.

Exit criteria

This issue can be closed once all @web dependencies have been updated to the most recent versions and there are no test runner issues.

@blackfalcon blackfalcon added auro-datepicker not-reviewed Issue has not been reviewed by Auro team members Type: Perf Performance update to existing code labels Jan 7, 2024
@blackfalcon blackfalcon changed the title NPM update causes tests to fail NPM update @web/test-runner causes tests to fail Jan 23, 2024
@jason-capsule42 jason-capsule42 removed not-reviewed Issue has not been reviewed by Auro team members Type: Perf Performance update to existing code labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants