Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIKE: auro-drawer: scoped scrolling #20

Open
braven112 opened this issue Jun 21, 2024 · 1 comment
Open

SPIKE: auro-drawer: scoped scrolling #20

braven112 opened this issue Jun 21, 2024 · 1 comment

Comments

@braven112
Copy link
Member

braven112 commented Jun 21, 2024

Is your feature request related to a problem? Please describe.

When a drawer needs to scroll we can have a situation where there are two scroll bars side by side. When the drawer is open though a user really only wants to scroll the drawer content, not the entire page.

Describe the solution you'd like

We can fix this by adding overflow: hidden to the body when a drawer is in an open state and then remove that line when the drawer is closed. We can likely do something similar in auro-dialog

Describe alternatives you've considered

Hide a scroll bar with css but that isn't well supported accross browsers.

Additional context

This is related to the fix we did on #17

@braven112 braven112 added not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature auro-drawer labels Jun 21, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Jun 24, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Jun 24, 2024
@Patrick-Daly-AA Patrick-Daly-AA changed the title auro-drawer: scoped scrolling SPIKE: auro-drawer: scoped scrolling Jun 24, 2024
@Patrick-Daly-AA
Copy link

Questions to answer with this SPIKE:

  1. What is a real world scenario where the page being a drawer (or dialog) would want to be scrolled?
  2. In what cases do we expect the scroll bar to appear?
  3. Determine if we want to do this in Dialog or Drawer (IE, the two scroll bars right next to each other case)

@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants