Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size reduction of content at breakpoint not within design spec #102

Open
blackfalcon opened this issue Dec 2, 2023 · 0 comments
Open

Size reduction of content at breakpoint not within design spec #102

blackfalcon opened this issue Dec 2, 2023 · 0 comments
Assignees
Labels
auro-flight not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Dec 2, 2023

Please verify the version of auro-flight you have installed

@latest

Please describe the bug

Discussed in #101

Originally posted by blackfalcon December 1, 2023

Design left, Implementation right:
image

It should use heading-300, for breakpoint-sm (320px-576px).

There are 2 issues:

  1. The sizes changing at a 659px breakpoint instead of 575px. (We have auro XS as 320px-575px)
  2. While a smaller size does appear, it does not match the design spec exactly. (I did comment on the issue requesting the change, but was never asked to review implementation before it was released.)

Design spec

https://www.figma.com/file/4e5FcfFlEhnSW9GveMlKnj/Flight-Line?type=design&node-id=160-7273&mode=design&t=6C51ZphF3iMnHCRM-0

Reproducing the error on the docsite

This issue cannot be reproduced on the Auro docsite

Expected behavior

The size of the content changes should update per the expectation of the design spec.

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Additional context

The breakpoint is using the legacy var(--auro-breakpoint-sm) which resolved at 660px not the desired var(--ds-grid-breakpoint-sm) that resolved at 576px. bbfd5bf

This issue is because the element has not yet been updated with the latest versions of WCSS and Auro Design Tokens.

Exit criteria

This issue can be closed once a user can reduce the size of the browser to the specified breakpoint and the type reduces in size as specified by the design spec.

This issue CANNOT be closed without approval from an Auro designer.

@blackfalcon blackfalcon added Type: Bug Bug or Bug fixes not-reviewed Issue has not been reviewed by Auro team members auro-flight labels Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-flight not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes
Projects
None yet
Development

No branches or pull requests

2 participants