Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyperlinks with icons #132

Open
blackfalcon opened this issue Jul 14, 2022 · 1 comment
Open

Hyperlinks with icons #132

blackfalcon opened this issue Jul 14, 2022 · 1 comment
Labels
auro-hyperlink not-reviewed Issue has not been reviewed by Auro team members Type: Documentation Documentation only changes

Comments

@blackfalcon
Copy link
Member

General Support Request

It is my general feeling that when there is an icon with a hyperlink element, the icon should NOT be inside the hyperlink slot.

Icons are decorative content and typically hidden from screen readers. Also, placing the icon inside the slot creates an undesirable UI when focus-visible is activated.

75d1f482-ac7c-4d6f-bf47-05e00e8a8e6a

Support request

Update Auro docs to illustrate the anti-pattern and propose a standard opinion of use.

The following is the pattern suggested NOT to follow.

a4ad6265-a1d8-4305-9713-cc67e48d333c
@blackfalcon blackfalcon added Type: Documentation Documentation only changes auro-hyperlink not-reviewed Issue has not been reviewed by Auro team members labels Jul 14, 2022
@blackfalcon
Copy link
Member Author

@DZwell ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auro-hyperlink not-reviewed Issue has not been reviewed by Auro team members Type: Documentation Documentation only changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blackfalcon