Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-compliant ESM code references #52

Open
blackfalcon opened this issue Oct 23, 2024 · 0 comments · May be fixed by #53
Open

Non-compliant ESM code references #52

blackfalcon opened this issue Oct 23, 2024 · 0 comments · May be fixed by #53
Assignees
Labels
auro-nav not-reviewed This issue has not yet been reviewed by the Auro team Type: Bug Bug or Bug fixes

Comments

@blackfalcon
Copy link
Member

blackfalcon commented Oct 23, 2024

Please verify the version of auro-nav you have installed

@latest

Please describe the bug

See the following code

auro-nav/src/auro-nav.js

Lines 24 to 25 in 0ae9421

import colorCss from "./color-css";
import tokensCss from "./tokens-css";

Import endpoint does not have syntax prefix causing consumer's build to break.

Reproducing the error on the docsite

This issue cannot be reproduced on the Auro docsite

Expected behavior

Updated components should not break build pipelines.

What browsers are you seeing the problem on?

n/a

Additional context

n/a

Exit criteria

This issue can be closed once the incomplete code has been updated.

@blackfalcon blackfalcon added auro-nav not-reviewed This issue has not yet been reviewed by the Auro team Type: Bug Bug or Bug fixes labels Oct 23, 2024
sun-mota added a commit that referenced this issue Oct 24, 2024
…e extension on import line #52

- Update dependency versions
- Update not to omit the file extension on import line
- `AuroNav.register` is to easily register the element without extra importing
- `import "@aurodesignsystem/auro-nav"` will still register this element to <auro-nav>
- `import { AuroNav } from '../src/auro-nav.js` wont register this element until `AuroNav.register` gets called
- Same change on `AuroBreadcrumb` and `AuroAnchorlink`
- Update AuroNav to work with customized `AuroBreadcrumb` and `AuroAnchorlink`
sun-mota added a commit that referenced this issue Oct 24, 2024
…e extension on import line #52

- Update dependency versions
- Update not to omit the file extension on import line
- `AuroNav.register` is to easily register the element without extra importing
- `import "@aurodesignsystem/auro-nav"` will still register this element to <auro-nav>
- `import { AuroNav } from '../src/auro-nav.js` wont register this element until `AuroNav.register` gets called
- Same change on `AuroBreadcrumb` and `AuroAnchorlink`
- Update AuroNav to work with customized `AuroBreadcrumb` and `AuroAnchorlink`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-nav not-reviewed This issue has not yet been reviewed by the Auro team Type: Bug Bug or Bug fixes
Projects
None yet
3 participants