Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-skeleton: Theming support #23

Closed
braven112 opened this issue Nov 7, 2023 · 0 comments · Fixed by #24
Closed

auro-skeleton: Theming support #23

braven112 opened this issue Nov 7, 2023 · 0 comments · Fixed by #24
Assignees
@fajar-apri-alaska
Labels
not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature

Comments

@braven112
Copy link
Member

Is your feature request related to a problem? Please describe.

This is regarding theming updates that need to happen to nearly all auro components

Describe the solution you'd like

  1. All tokens with the prefix --auro need to be renamed to --ds so they work with the new WCSS v5 update.
  2. The WCSS package needs to be updated to ^5.0.0 and the import paths in the component *.scss files need to be updated as well

Describe alternatives you've considered

None

Additional context

Reference this auro-button pr AlaskaAirlines/auro-button#231
And this auro-hyperlink pr AlaskaAirlines/auro-hyperlink#185

Exit criteria

All tokens referencing --auro have been updated.
@braven112 braven112 added Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team members labels Nov 7, 2023
fajar-apri-alaska added a commit that referenced this issue Nov 9, 2023
@fajar-apri-alaska
perf(token): update token per new theming #23
a710a33 
- add fallback values to the tokens
- keep the old WCSS because of still being used in demo/style.scss

Changes to be committed:
	modified:   demo/style.scss
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style-fixed.css.map
	modified:   src/style-fixed.scss
	modified:   src/style.css.map
	modified:   src/style.scss
@fajar-apri-alaska fajar-apri-alaska mentioned this issue Nov 9, 2023
Merged
3 tasks
@fajar-apri-alaska fajar-apri-alaska linked a pull request Nov 9, 2023 that will close this issue
Update CSS token per new design system theming capability #24
Merged
3 tasks
@blackfalcon blackfalcon mentioned this issue Nov 9, 2023
Closed
fajar-apri-alaska added a commit that referenced this issue Nov 10, 2023
@fajar-apri-alaska
perf(token): update token per new theming #23
0efc21b 
- add fallback values to the tokens
- keep the old WCSS because of still being used in demo/style.scss

Changes to be committed:
	modified:   demo/style.scss
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style-fixed.css.map
	modified:   src/style-fixed.scss
	modified:   src/style.css.map
	modified:   src/style.scss
jason-capsule42 pushed a commit that referenced this issue Nov 16, 2023
@fajar-apri-alaska @jason-capsule42
perf(token): update token per new theming #23
0305927 
- add fallback values to the tokens
- keep the old WCSS because of still being used in demo/style.scss

Changes to be committed:
	modified:   demo/style.scss
	modified:   package-lock.json
	modified:   package.json
	modified:   src/style-fixed.css.map
	modified:   src/style-fixed.scss
	modified:   src/style.css.map
	modified:   src/style.scss
@jason-capsule42 jason-capsule42 mentioned this issue Nov 16, 2023
Merged
6 tasks
blackfalcon pushed a commit that referenced this issue Jan 30, 2024
@semantic-release-bot
chore(release): 2.1.1 [skip ci]
67f0ed7 
## [2.1.1](v2.1.0...v2.1.1) (2024-01-30)

### Performance Improvements

* **deps:** update dependencies to latest version ([2eb3ce5](2eb3ce5))
* **imports:** update imports to [@AuroDesignSystem](https://github.com/aurodesignsystem) ([858660b](858660b))
* **token:** update token per new theming [#23](#23) ([0305927](0305927))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fajar-apri-alaska fajar-apri-alaska

Labels
not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update CSS token per new design system theming capability AlaskaAirlines/auro-skeleton
4 participants
@blackfalcon @braven112 @fajar-apri-alaska @Patrick-Daly-AA