Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color tokens for theming support #31

Closed
2 tasks
jordanjones243 opened this issue Mar 13, 2024 · 2 comments · Fixed by #32 or #34
Closed
2 tasks

Update color tokens for theming support #31

jordanjones243 opened this issue Mar 13, 2024 · 2 comments · Fixed by #32 or #34
Assignees

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 13, 2024

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243 jordanjones243 added Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team members auro-skeleton labels Mar 13, 2024
@jordanjones243
Copy link
Contributor Author

  • Tier 1
    • Background-color: var(--ds-color-brand-neutral-100, $ds-color-brand-neutral-100);
    • Background-image: linear-gradient(to right,var(--ds-color-brand-neutral-100, $ds-color-brand-neutral-100) 10%,var(--ds-color-brand-neutral-200, $ds-color-brand-neutral-200) 40%,var(--ds-color-brand-neutral-100, $ds-color-brand-neutral-100) 60%);

@jason-capsule42 jason-capsule42 linked a pull request Mar 18, 2024 that will close this issue
9 tasks
blackfalcon pushed a commit that referenced this issue Jul 9, 2024
# [2.2.0-beta.1](v2.1.5...v2.2.0-beta.1) (2024-07-09)

### Features

* refactor color token structure with tier 3 tokens [#31](#31) ([577c0cc](577c0cc))
@jordanjones243 jordanjones243 linked a pull request Aug 16, 2024 that will close this issue
6 tasks
@jordanjones243 jordanjones243 removed the not-reviewed Issue has not been reviewed by Auro team members label Sep 19, 2024
@jordanjones243
Copy link
Contributor Author

Need design to revise the semantic tokens being used within the tokens.scss file.

jordanjones243 added a commit that referenced this issue Sep 27, 2024
BREAKING CHANGE: trigger major release for color theme support #31
jordanjones243 added a commit that referenced this issue Sep 27, 2024
BREAKING CHANGE: trigger major release for color theme support #31
blackfalcon pushed a commit that referenced this issue Sep 27, 2024
# [3.0.0-beta.1](v2.2.0-beta.1...v3.0.0-beta.1) (2024-09-27)

### Bug Fixes

* resolve minor color theming issues ([894b6fd](894b6fd))

### Features

* add tag name as attribute when custom registered ([d8c3f71](d8c3f71))

### Performance Improvements

* refactor custom component registration config ([147af17](147af17))
* update dependencies ([438c6b1](438c6b1))

### BREAKING CHANGES

* trigger major release for color theme support #31
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
# [2.2.0-beta.1](v2.1.5...v2.2.0-beta.1) (2024-07-09)

### Features

* refactor color token structure with tier 3 tokens [#31](#31) ([577c0cc](577c0cc))
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
BREAKING CHANGE: trigger major release for color theme support #31
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
# [3.0.0-beta.1](v2.2.0-beta.1...v3.0.0-beta.1) (2024-09-27)

### Bug Fixes

* resolve minor color theming issues ([894b6fd](894b6fd))

### Features

* add tag name as attribute when custom registered ([d8c3f71](d8c3f71))

### Performance Improvements

* refactor custom component registration config ([147af17](147af17))
* update dependencies ([438c6b1](438c6b1))

### BREAKING CHANGES

* trigger major release for color theme support #31
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
# [3.0.0](v2.1.5...v3.0.0) (2024-09-30)

### Bug Fixes

* resolve minor color theming issues ([37d636c](37d636c))

### Features

* add tag name as attribute when custom registered ([99a7b02](99a7b02))
* refactor color token structure with tier 3 tokens [#31](#31) ([ad5bdfa](ad5bdfa))

### Performance Improvements

* refactor custom component registration config ([a5534f5](a5534f5))
* update dependencies ([67b0b6c](67b0b6c))

### BREAKING CHANGES

* trigger major release for color theme support #31
@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants