-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update component registration logic #39
Labels
Comments
sun-mota
added
Type: Bug
Bug or Bug fixes
not-reviewed
Issue has not been reviewed by Auro team members
auro-skeleton
labels
Oct 17, 2024
6 tasks
sun-mota
added a commit
that referenced
this issue
Oct 21, 2024
`AuroSkeleton.register` is to easily register the element without extra importing `import '@aurodesignsystem/auro-skeleton'` will still register this element to `<auro-skeleton>` `import { AuroSkeleton } from '../src/auro-skeleton.js'` wont register this element until `AuroSkeleton.register` gets called
jason-capsule42
removed
Type: Bug
Bug or Bug fixes
not-reviewed
Issue has not been reviewed by Auro team members
labels
Oct 23, 2024
sun-mota
added a commit
that referenced
this issue
Oct 24, 2024
`AuroSkeleton.register` is to easily register the element without extra importing `import '@aurodesignsystem/auro-skeleton'` will still register this element to `<auro-skeleton>` `import { AuroSkeleton } from '../src/auro-skeleton.js'` wont register this element until `AuroSkeleton.register` gets called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please verify the version of auro-skeleton you have installed
No response
Please describe the bug
Default import of index.js should register the default custom element only.
import of the component class should not register the custom element at all.
Remove all registration of custom-${component name} from the JS and only register as part of ./demo/index.js
Reproducing the error
None
Expected behavior
No response
What browsers are you seeing the problem on?
No response
Additional context
No response
Exit criteria
No response
The text was updated successfully, but these errors were encountered: