Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update color tokens for theming support #37

Closed
2 tasks
jordanjones243 opened this issue Mar 13, 2024 · 2 comments · Fixed by #38 or #44
Closed
2 tasks

Update color tokens for theming support #37

jordanjones243 opened this issue Mar 13, 2024 · 2 comments · Fixed by #38 or #44
Assignees
@jordanjones243
Labels
auro-toast

Comments

@jordanjones243
Copy link
Contributor

jordanjones243 commented Mar 13, 2024 •
edited by braven112
Loading

General Support Request

In order to make Auro components themeable, we need to make sure there are no hard-coded and correct semanticly named tokens within the component. There also needs to be investigation around border rules which have a combination of size and color tokens, making them more complex, as well as background-color and color rules.

Possible Solution

Work with designers to figure out what tokens need updated values or renamed.

Additional context

This work stems from theming work happening to all Auro components:

Rules and tokens to be edited can be found in the comments.

Acceptance Criteria:

  • All tier 3 token names have been implemented.
  • Colors identified below have been updated to their tier 3 token name.
@jordanjones243 jordanjones243 added auro-toast not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature labels Mar 13, 2024
@jordanjones243
Copy link
Contributor Author

  • Tier 1
    • Background color: var(--ds-color-brand-gray-400, $ds-color-brand-gray-400);
  • Hardcoded
    • Solid
    • Transparent

jordanjones243 added a commit that referenced this issue Mar 15, 2024
@jordanjones243
feat(tokens): update semantic color token names #37
3515424
@jordanjones243 jordanjones243 mentioned this issue Mar 15, 2024
Merged
9 tasks
@jordanjones243 jordanjones243 linked a pull request Mar 15, 2024 that will close this issue
Update semantic color token names #38
Merged
9 tasks
@jordanjones243 jordanjones243 removed the not-reviewed Issue has not been reviewed by Auro team members label May 28, 2024
jordanjones243 added a commit that referenced this issue Jun 5, 2024
@jordanjones243
feat: refactor color token structure with tier 3 tokens #37
5d85f89
jordanjones243 added a commit that referenced this issue Jun 19, 2024
@jordanjones243
feat: refactor color token structure with tier 3 tokens #37
307db52
blackfalcon pushed a commit that referenced this issue Jun 22, 2024
@jordanjones243 @blackfalcon
feat: refactor color token structure with tier 3 tokens #37
965820f
jason-capsule42 pushed a commit that referenced this issue Jul 9, 2024
@jordanjones243 @jason-capsule42
feat: refactor color token structure with tier 3 tokens #37
5c5dbc5
jason-capsule42 pushed a commit that referenced this issue Jul 9, 2024
@jordanjones243 @jason-capsule42
feat: refactor color token structure with tier 3 tokens #37
4c3e3ce
blackfalcon pushed a commit that referenced this issue Jul 9, 2024
@semantic-release-bot
chore(release): 1.2.0-beta.1 [skip ci]
80f9822 
# [1.2.0-beta.1](v1.1.6...v1.2.0-beta.1) (2024-07-09)

### Bug Fixes

* **hover:** corrects minor visual jump in close button on hover ([7e1a45d](7e1a45d))

### Features

* refactor color token structure with tier 3 tokens [#37](#37) ([4c3e3ce](4c3e3ce))

### Performance Improvements

* replace hard coded values with tokens ([f31eb13](f31eb13))
@jordanjones243 jordanjones243 mentioned this issue Aug 16, 2024
Merged
6 tasks
@jordanjones243 jordanjones243 linked a pull request Aug 16, 2024 that will close this issue
Move theming support from Beta to Main #44
Merged
6 tasks
@jordanjones243
Copy link
Contributor Author

Blocked by auro-button color theming release.

jordanjones243 added a commit that referenced this issue Sep 26, 2024
@jordanjones243
perf: update dependencies
f045f67 
BREAKING CHANGE: trigger major release for theming support #37
jordanjones243 added a commit that referenced this issue Sep 26, 2024
@jordanjones243
perf: update dependencies
2831c72 
BREAKING CHANGE: trigger major release for theming support #37
blackfalcon pushed a commit that referenced this issue Sep 26, 2024
@semantic-release-bot
chore(release): 2.0.0-beta.1 [skip ci]
a9f4431 
# [2.0.0-beta.1](v1.2.0-beta.2...v2.0.0-beta.1) (2024-09-26)

### Features

* add tag name as attribute when custom registered ([c140d41](c140d41))

### Performance Improvements

* refactor custom component registration config ([ec76cc7](ec76cc7))
* update dependencies ([2831c72](2831c72))

### BREAKING CHANGES

* trigger major release for theming support #37
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
@jordanjones243 @jason-capsule42
feat: refactor color token structure with tier 3 tokens #37
6c5798e
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
@semantic-release-bot @jason-capsule42
chore(release): 1.2.0-beta.1 [skip ci]
77f0c33 
# [1.2.0-beta.1](v1.1.6...v1.2.0-beta.1) (2024-07-09)

### Bug Fixes

* **hover:** corrects minor visual jump in close button on hover ([7e1a45d](7e1a45d))

### Features

* refactor color token structure with tier 3 tokens [#37](#37) ([4c3e3ce](4c3e3ce))

### Performance Improvements

* replace hard coded values with tokens ([f31eb13](f31eb13))
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
@jordanjones243 @jason-capsule42
perf: update dependencies
cbed764 
BREAKING CHANGE: trigger major release for theming support #37
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
@semantic-release-bot @jason-capsule42
chore(release): 2.0.0-beta.1 [skip ci]
3076fa9 
# [2.0.0-beta.1](v1.2.0-beta.2...v2.0.0-beta.1) (2024-09-26)

### Features

* add tag name as attribute when custom registered ([c140d41](c140d41))

### Performance Improvements

* refactor custom component registration config ([ec76cc7](ec76cc7))
* update dependencies ([2831c72](2831c72))

### BREAKING CHANGES

* trigger major release for theming support #37
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
08853a7 
# [2.0.0](v1.1.6...v2.0.0) (2024-09-30)

### Bug Fixes

* **hover:** corrects minor visual jump in close button on hover ([b323af2](b323af2))

### Features

* add tag name as attribute when custom registered ([9ee3022](9ee3022))
* refactor color token structure with tier 3 tokens [#37](#37) ([6c5798e](6c5798e))
* **version:** implement custom versioned components ([cf0b4da](cf0b4da))

### Performance Improvements

* **icon:** update to use dynamic named icon ([d197718](d197718))
* refactor custom component registration config ([f53c1a2](f53c1a2))
* replace hard coded values with tokens ([e876f93](e876f93))
* update dependencies ([cbed764](cbed764))

### BREAKING CHANGES

* trigger major release for theming support #37
@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-toast
Projects
None yet
Milestone
No milestone
3 participants
@jason-capsule42 @jordanjones243 @Patrick-Daly-AA