Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better colors for "everyone" and "logged in users" #2

Open
apeisa opened this issue Jan 29, 2014 · 3 comments
Open

Better colors for "everyone" and "logged in users" #2

apeisa opened this issue Jan 29, 2014 · 3 comments

Comments

@apeisa
Copy link

apeisa commented Jan 29, 2014

Current "light gray" looks to me like "disabled". I would suggest rendering everyone as green and logged in users as orange. What do you think?

@teppokoivula
Copy link
Member

You're absolutely right in that light gray doesn't work there. I think I'll give this some thought -- would really prefer a subtle and adaptive yet still informative solution.

Main reason for current color instead of something more distinctive was that I'm hoping this module will look (at least) OK in most themes out-of-the-box.. and probably the best way to achieve that is having as few "strong" style settings as possible :)

@teppokoivula
Copy link
Member

Writing this up so that I don't forget it instantly: configurable styles could make sense here.. or is this just extra noise, something that people won't a) notice, b) remember or c) event want to use?

@apeisa
Copy link
Author

apeisa commented Jan 29, 2014

I wouldn't bother with theming too much. This is only for admins and something that still could be overwritten through css. My vote goes for convention over configuration here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants