Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache tokens in memory #32

Open
AlexGustafsson opened this issue Dec 23, 2024 · 2 comments
Open

Cache tokens in memory #32

AlexGustafsson opened this issue Dec 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@AlexGustafsson
Copy link
Owner

Processing an image can require multipel calls to an OCI registry, especially if there are many pages worth of tags to retrieve. Currently, each such request results in one uncached request to get a token for the OCI registry. We should try to cache these in memory to reduce the number of requests made to registries.

@AlexGustafsson AlexGustafsson added the enhancement New feature or request label Dec 23, 2024
@AlexGustafsson
Copy link
Owner Author

GHCR doesn't report the lifetime of tokens, making this quite difficult. Docker Hub uses a JWT, but relying on the token's format might not be a good idea in the long run.

@AlexGustafsson
Copy link
Owner Author

Registries SHOULD use Www-Auth, so perhaps just try once and then, if it doesn't work, use the appropriate authenticator with a token. If it fails, update the token? There are some standard warnings and errors for things like a token being expired, but it's unclear how many registries actually implement them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant