Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling don't work in Chrome #15

Open
jcubic opened this issue May 28, 2018 · 2 comments
Open

Scrolling don't work in Chrome #15

jcubic opened this issue May 28, 2018 · 2 comments

Comments

@jcubic
Copy link

jcubic commented May 28, 2018

You're using old version of jQuery Terminal that is using node that you run plugin on to scroll. The correct behavior (which is weird) is that you need to get scrollHeight from body but scrollTop set/get to html (or reversed), I use $('html,body') but not in Safari that need body otherwise it will not work at all.

So you need to update jQuery Terminal in order to fix scrolling issue.

@AlexNisnevich
Copy link
Owner

Unfortunately a lot of my styling in ECMAchine is dependent on the very old version of jquery-terminal that I'm using (v0.4.11).

@jcubic Is there any way to hot-fix the scrolling issue without updating jquery-terminal to >v0.x?

@jcubic
Copy link
Author

jcubic commented Jan 11, 2021

Sorry I don't think it's good idea to patch version that was released years ago.

Maybe you should consider updating the library. Unless you don't want to work on this project anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants