Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample pages to the sitemap #874

Open
arielsvn opened this issue Mar 12, 2020 · 2 comments
Open

Add sample pages to the sitemap #874

arielsvn opened this issue Mar 12, 2020 · 2 comments

Comments

@arielsvn
Copy link
Contributor

Now that we enabled server-side rendering we can take advantage of this opportunity with #863.

Google has already started indexing several sample pages. We can do much better if we add all of our 1MM samples to the sitemap.

image

The current samples page GSM1249275 has only basic metadata about each sample. I think it would be useful to add all the processing information and the additional metadata directly on the page. @dvenprasad do you have any suggestions on how to add these? It would be great if we were able to use the same components that we have inside the dialogs.

Also, we should change the url and use something more meaningful, maybe something similar to the experiments like /samples/GSM123-sample-title-slug.

@dvenprasad
Copy link
Member

Link them back to the experiment?

Also, can we display all the metadata in the Additional Metadata modal under Sample Metadata Fields as a section instead of modal style display? It would be good to add the filter component to the page too. Not sure if that is too much change from what is in the modal but tweak things as needed.

@dvenprasad
Copy link
Member

Tagging this as exploration. I think we decided to not show the sample pages since it's mostly a log which was used internally. It's not immediately apparent how to access this page from the front-end, but we should remove links to it altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants