Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename context states for DatasetManagerContext #392

Open
nozomione opened this issue Oct 18, 2024 · 0 comments · May be fixed by #434
Open

Rename context states for DatasetManagerContext #392

nozomione opened this issue Oct 18, 2024 · 0 comments · May be fixed by #434
Assignees

Comments

@nozomione
Copy link
Member

nozomione commented Oct 18, 2024

Context

We currently defined the following states for DatasetManagerContext:

  • dataset : used to store the user-created dataset (i.e., My Dataset) in localStorage
  • datasetId: used to store the user-created dataset ID (i.e., My Dataset's ID) in localStorage

To differentiate other datasets (e.g., shared, one-off downloads) in the codebase, we want to change these state names to explicitly indicate that they are solely used for users' "My Datasets".

Problem or idea

We should rename these states in the dataset manager context and adjust their references throughout the codebase.

Solution or next step

  1. Rename theDatasetManagerContext states:
  • dataset to myDataset
  • datasetId to myDatasetId
  1. Update these state references in the codebase to reflect these changes
@nozomione nozomione self-assigned this Oct 18, 2024
@nozomione nozomione changed the title Rename context states in DatasetManagerContext Rename context states for DatasetManagerContext Jan 6, 2025
@nozomione nozomione linked a pull request Jan 6, 2025 that will close this issue
4 tasks
@nozomione nozomione linked a pull request Jan 6, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant