Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't add hashes to file names #33

Open
donovanr opened this issue Mar 9, 2020 · 1 comment
Open

don't add hashes to file names #33

donovanr opened this issue Mar 9, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@donovanr
Copy link

donovanr commented Mar 9, 2020

trading clarity for efficiency with an option to not mangle the names of the files would make using this a lot more friendly.

the cardio fish data set is an example, where mysterious hash like strings confused pretty much everyone, and will definitely be odd to end-user biologists.

@donovanr donovanr added the enhancement New feature or request label Mar 9, 2020
@evamaxfield
Copy link
Contributor

How do you propose I should counteract this:

# Just using val.name could result in files that shouldn't be grouped being grouped
# Example column:
# SourceReadpath
# a/0.tiff
# a/1.tiff
# b/0.tiff
# b/1.tiff
# Even though there are four files, this would result in both a/0.tiff and b/0.tiff, and,
# a/1.tiff and b/1.tiff being grouped together. To solve this we can prepend a the first couple
# of characters from a hash of the fully resolved path to the logical key.

@evamaxfield evamaxfield removed their assignment Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants