Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SweepFormula: Automatic markers vs lines usage looks odd #2281

Open
t-b opened this issue Oct 15, 2024 · 3 comments · May be fixed by #2284
Open

SweepFormula: Automatic markers vs lines usage looks odd #2281

t-b opened this issue Oct 15, 2024 · 3 comments · May be fixed by #2284
Assignees
Labels
question Further information is requested SweepFormula

Comments

@t-b
Copy link
Collaborator

t-b commented Oct 15, 2024

@t-b I'm seeing the data plotting style change in the middle of the plot. It seems like the method for changing the style depending on the number of points is being applied to the same plot

image

Originally posted by @timjarsky in #2061 (comment)

This is also the behaviour in main 818d5fc (Merge pull request #2277 from AllenInstitute/bugfix/2277-make-tests-pass-with-ip10, 2024-10-14).

short = 1...250 * 2
long  = 1...2000

$short 

with

$long

gives

grafik

The reason for this is that we have a heuristic to determine if we want to use markers or lines. We usually use markers for less than 1k points.

There is also the option to override the trace style per operation, e.g. we currently always use lines for fit. We could do the same for data

@t-b t-b added question Further information is requested SweepFormula labels Oct 15, 2024
@timjarsky
Copy link
Collaborator

@t-b, thanks for creating the issue. I did not realize that contiguous epochs from the same sweep resulted in independent arrays/waves. What do you think about setting the trace style based on the amount of data/points from the same sweep?

@t-b
Copy link
Collaborator Author

t-b commented Oct 18, 2024

What do you think about setting the trace style based on the amount of data/points from the same sweep?

While technically possible, this is quite a bit off effort. Is there a case where you would like to have markers for sweep data? I think I'd always prefer line style.

@timjarsky
Copy link
Collaborator

Forcing line style for sweep data should have the same effect - I like it! Thanks @t-b

@t-b t-b self-assigned this Oct 21, 2024
@t-b t-b linked a pull request Oct 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested SweepFormula
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants