Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FHIR] support configuring kafka saslJaasConfig from a secret #26

Open
lmsurpre opened this issue Sep 2, 2021 · 0 comments
Open

[FHIR] support configuring kafka saslJaasConfig from a secret #26

lmsurpre opened this issue Sep 2, 2021 · 0 comments

Comments

@lmsurpre
Copy link
Collaborator

lmsurpre commented Sep 2, 2021

For our 0.1.0 we introduced support for passing sensitive info like passwords via helm secrets (documented in https://github.com/Alvearie/alvearie-helm/pull/25/files) as opposed to hardcoding them or forcing users.

It turns out that we have some sensitive info in the kafka configurations (both audit and notifications) and I think we should use a similar approach for that. The specific field with the connection info in this case is the saslJaasConfig, although only a small part of that is actually sensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant