Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"generated" punctuation in statement and figure labels #213

Closed
pkra opened this issue Aug 5, 2024 · 5 comments
Closed

"generated" punctuation in statement and figure labels #213

pkra opened this issue Aug 5, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@pkra
Copy link
Member

pkra commented Aug 5, 2024

It seems the behavior is not quite consistent.

@pkra pkra added this to the 2024 milestone Aug 5, 2024
@pkra pkra added the bug Something isn't working label Aug 5, 2024
@davidmjones
Copy link
Contributor

@pkra I reviewed all the places where texml generates <title/> or
<label/> elements.

This includes the table of contents, where I noticed that we've been omitting the section signs (§) that GSM uses in front of section numbers in the TOC. Those will now be included.

Do we want to use <x/> elements in bibliography labels?

<label><x>[</x>1<x>]</x></label>

instead of

<label>[1]</label>

It's probably better to use them for consistency.

@pkra
Copy link
Member Author

pkra commented Aug 5, 2024

This includes the table of contents, where I noticed that we've been omitting the section signs (§) that GSM uses in front of section numbers in the TOC. Those will now be included.

Ok. (I only recently added them downstream but this will be more robust.)

Do we want to use elements in bibliography labels?

Sounds good.

@pkra
Copy link
Member Author

pkra commented Aug 6, 2024

The changes are looking good.

But I noticed that theorems with label and title have the generated . on the label instead of the title (which does not match TeX).

@pkra
Copy link
Member Author

pkra commented Aug 6, 2024

I think the algorithm environment still needs punctuation support,e.g., gsm241 has a few, they produce : in PDF.

@pkra
Copy link
Member Author

pkra commented Jan 27, 2025

I've just opened #235.

Otherwise, this issue seems fixed.

@pkra pkra closed this as completed Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants