Update Numpy to Version 1.23.2
#52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eedstock into update_to_1.23.2
chenghlee
requested changes
Sep 7, 2022
chenghlee
reviewed
Sep 15, 2022
Comment on lines
+123
to
+130
| {% set tests_to_skip = tests_to_skip + " or test_scalarmath" %} | ||
| {% set tests_to_skip = tests_to_skip + " or test_system_info" %} | ||
| {% set tests_to_skip = tests_to_skip + " or test_extending" %} | ||
| {% set tests_to_skip = tests_to_skip + " or test_typing" %} | ||
| {% set tests_to_skip = tests_to_skip + " or test_io" %} | ||
| {% set tests_to_skip = tests_to_skip + " or test_mem_policy" %} # [ppc64le or s390x] | ||
| {% set tests_to_skip = tests_to_skip + " or test_generalized_herm_cases" %} | ||
| {% set tests_to_skip = tests_to_skip + " or test_herm_cases " %} |
There was a problem hiding this comment.
Having to disable this many tests, especially on x86_64, is an indication that something else is wrong with our build. The fix lies elsewhere; i.e., not in disabling tests.
varlackc
commented
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpyversion1.23.2https://github.com/numpy/numpy/tree/v1.23.2
https://github.com/numpy/numpy/blob/v1.23.2/doc/changelog/1.23.2-changelog.rst
https://github.com/conda-forge/numpy-feedstock/issues
currently there are two open issues in the upstream.
One is the osx-arm cross-complile issues
f2py entry point with non-functioning shebang in osx-arm cross-compile conda-forge/numpy-feedstock#276
the other issues is a strange astype casting behavior on MacOS x86_64
strange astype casting behavior on MacOS x86_64 conda-forge/numpy-feedstock#249
dev_urlhttps://github.com/numpy/numpy
doc_urlhttps://numpy.org/doc/stable/reference/
spdxcompliantBSD-3-Clause
BSD
build_numberis correctsetuptoolswheelpipin the test sectionarchitecture specificorNoarchResults:
Based on the research findings and the results we can conclude
that it is relatively safe to update
numpyto version1.23.2