Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial sheet on top of .sheet() gets cut off #169

Open
emilloohoo opened this issue Jan 12, 2023 · 1 comment
Open

Partial sheet on top of .sheet() gets cut off #169

emilloohoo opened this issue Jan 12, 2023 · 1 comment

Comments

@emilloohoo
Copy link

Our app has a lot of .sheet() modifiers to pop up over our views. We are using your PartialSheet to have an additional popup over our sheet, but are noticing that the edge of the bottom gets cut off, due to the height of the .sheet() behind it. We added the .attachPartialSheetToRoot() to the view that .sheet() encapsulates. I believe that the root view's height is what is used for calculation, so when the root view is a sheet, the height is smaller so the calculated height reduces. I have tried attachPartialSheetToRoot on the .sheet().attachPartialSheetToRoot but that doesn't work at all.

Any ideas to when this can be fixed? We have to add padding right now but want to reuse the view in places that don't have it popup on a sheet and instead just the static view, so we don't want the padding in some cases.

@AndreaMiotto
Copy link
Owner

Hello, try with the new version, if you still have a problem, can you provide a sample please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants