Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cleaning the wrong top node #523

Closed
AndyTheFactory opened this issue Oct 24, 2023 · 1 comment
Closed

fix cleaning the wrong top node #523

AndyTheFactory opened this issue Oct 24, 2023 · 1 comment
Labels
PR-verify Has a PR, must be checked
Milestone
Release 0.9.1

Comments

@AndyTheFactory
Copy link
Owner

Issue by idoshamun
Thu Jun 17 15:18:52 2021
Originally opened as codelucas/newspaper#896

Before this change, top_node was cleaned and then copied to the clean_top_node.
I believe this is not the original intent and should be fixed because it creates confusion and there's no way to get the raw top_node. It's an issue I'm currently facing myself.

Thanks for your awesome work!

idoshamun included the following code: https://github.com/codelucas/newspaper/pull/896/commits
@AndyTheFactory AndyTheFactory added this to the Release 0.9.1 milestone Oct 30, 2023
@AndyTheFactory AndyTheFactory added the PR-verify Has a PR, must be checked label Oct 30, 2023
@AndyTheFactory
Copy link
Owner Author

fixed v0.9.1 see #497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR-verify Has a PR, must be checked
Projects
None yet
Milestone
Release 0.9.1
Development

No branches or pull requests
1 participant
@AndyTheFactory