Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search dialog not working properly #1

Open
Chiff opened this issue Aug 20, 2018 · 2 comments
Open

Search dialog not working properly #1

Chiff opened this issue Aug 20, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@Chiff
Copy link
Contributor

Chiff commented Aug 20, 2018

Describe the bug
Search dialog can't open node that isn't cached

To Reproduce
Steps to reproduce the behavior:

  1. Search for item not listed yet
  2. Search icon / Press enter
  3. Click on search result that wasn't listed yet
  4. See error in console

Expected behavior
It should open node

@Chiff Chiff added the bug Something isn't working label Aug 20, 2018
@mimoro
Copy link

mimoro commented Sep 5, 2019

Any news regarding this bug? Or do you maybe have a suggestion on how to do a workaround to avoid the bug if the folder hasn't been visited before?
Thanks!

@Chiff
Copy link
Contributor Author

Chiff commented Sep 18, 2019

No news yet. I hope this will be fixed soon.

This bug happens because when you want to jump to item that has not been fetched yet.

Fix would be made by extending backend API on route api/file/list with queryParam getParent: boolean that will return whole structure from root to item/node/file

Part of fix on frontend will be adjusting method that is GETting nodes and then merging inside TreeModel.nodes: NodeInterface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants