Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixelated image instead of high resolution im age displayed by default settings #7

Closed
kianmeng opened this issue Jul 20, 2023 · 6 comments
Labels
tmux Related to Tmux

Comments

@kianmeng
Copy link
Contributor

Description
Cannot display high resolution image.

To Reproduce
Steps to reproduce the behavior:

  1. pipx install termvisage
  2. wget https://user-images.githubusercontent.com/61663146/235449392-b464ff19-82ac-4c55-9244-e718bc999e98.png
  3. termvisage 235449392-b464ff19-82ac-4c55-9244-e718bc999e98.png

Expected behavior
Expect to see a high resolution image instead of pixelated image.

Screenshots
Screenshot from 2023-07-21 07-24-51

Desktop (please complete the following information, if applicable):

  • OS: Ubuntu
  • Version: 23.04
  • Kernel version (if applicable): 6.2.0

Smartphone (please complete the following information, if applicable):

  • Device: [e.g. Samsumg S20]
  • OS: [e.g. Android]
  • Version [e.g. 9 (Pie)]

Package info:

  • Python version: 3.11.2
  • Package version: 0.1.0 (note there is no -V arg)
  • Installation method: pipx

Terminal Emulator:

  • Name: Gnome Terminal, Kitty
  • Version: 3.48.0, 0.26.5

Additional context
Add any other context about the problem here.

@kianmeng kianmeng added the bug Something isn't working label Jul 20, 2023
@AnonymouX47
Copy link
Owner

AnonymouX47 commented Jul 20, 2023

Thanks for the report.

Unfortunately, what I see in the screenshot couldn't have been produced directly in either of the terminal emulators mentioned.

Did you run termvisage within tmux or some other terminal multiplexer?

@AnonymouX47 AnonymouX47 removed the bug Something isn't working label Jul 21, 2023
@kianmeng
Copy link
Contributor Author

I've tried disabling tmux, as well as create another new user account with bash shell without tmux to test it out. Issue remains the same.

@AnonymouX47
Copy link
Owner

The shell shouldn't matter.

Please, try the following:

  • Open a new Kitty Terminal window.
  • Ensure you aren't working within tmux or any other terminal multiplexer.
  • Run termvisage ...
  • Run echo $TERM_PROGRAM
  • Run kitty +kitten query_terminal
  • Share a full screenshot of the terminal window.

@kianmeng
Copy link
Contributor Author

Yup, it worked for me this time, after disabling tmux and use kitty, not gnome-terminal. Thanks.

$ echo $TERM_PROGRAM

$ kitty +kitten query_terminal
allow_hyperlinks: yes
bold_font: NotoSansMono-Bold
bold_italic_font: NotoSansMono-Bold
clipboard_control: write-clipboard write-primary read-clipboard-ask read-primary-ask
font_family: NotoSansMono-Regular
font_size: 11
italic_font: NotoSansMono-Regular
name: xterm-kitty
version: 0.26.5

Screenshot from 2023-07-22 12-54-11

@AnonymouX47
Copy link
Owner

Oh, great! You're welcome.

Also, I think it's worth noting the following:

  • support for tmux passthrough is underway. This will allow high-resolution images within tmux, though with certain limitations.
  • support a relatively new kitty graphics' Virtual Placements is underway, see Kitty terminal graphics support term-image#40 (comment). This will allow for proper display of images within terminal multiplexers, though it's only limited to the Kitty Terminal so far.

These features will be implemented in the library, term-image first and then incorporated herein.

Thanks.

@AnonymouX47
Copy link
Owner

AnonymouX47 commented Jul 22, 2023

Oh, great! You're welcome.

Also, I think it's worth noting the following:

  • support for tmux passthrough is underway. This will allow high-resolution images within tmux, though with certain limitations.
  • support for kitty graphics' Virtual Placements is underway, see Kitty terminal graphics support term-image#40 (comment). This will allow for proper display of images within terminal multiplexers, though it's only limited to the Kitty Terminal so far.

These features will be implemented in the library, term-image first and then incorporated herein.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tmux Related to Tmux
Projects
None yet
Development

No branches or pull requests

2 participants