New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial 11 -- loss function of Node2Vec class #14

Open

xianhong opened this issue Feb 4, 2023 · 0 comments

xianhong commented Feb 4, 2023

Reading the loss function of Node2Vec class (https://pytorch-geometric.readthedocs.io/en/latest/_modules/torch_geometric/nn/models/node2vec.html) , i feel the return value of "pos_loss + neg_loss" does not seem to take into account of 'num_negative_samples'. Shouldn't the loss function return "pos_loss + neg_loss * self.num_ negative_samples" instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment