ModbusTcpClient .Initialize throws Exception -> hard to catch / determine what went wrong

[JaggerJo]

Hey @Apollo3zehn 👋

First, great library - thanks for maintaining.

We are having a small problem with Initialize on the ModbusTcpClient. We want to periodically retry to connect if connecting fails. We could do that by wrapping the call to initialise in a try catch, the issue is that we'd need to catch all exceptions.

FluentModbus/src/FluentModbus/Client/ModbusTcpClient.cs

Lines 170 to 171 in bbd7dcd

	if (remoteEndpoint is not null && !tcpClient.ConnectAsync(remoteEndpoint.Address, remoteEndpoint.Port).Wait(ConnectTimeout))
	throw new Exception(ErrorMessage.ModbusClient_TcpConnectTimeout);

It would be nice to throw a special kind of exception here so that we can only catch e.g. FluentModbusException instead of Exception.

What do you think?

Are we completely missing something here?

[Apollo3zehn]

I see your point. But wouldn't a TimeoutException be more suitable?

I will put this issue on my v6 TODO list and I plan to release a breaking change release soon. Howevery I had a very turbulent year and already had to postpone it multiple times so I won't make any promises :-(

[JaggerJo]

Hey @Apollo3zehn,

Thanks for the response.

That would work too, yes.

I maintain OSS myself, I know how it goes.