From 8a1f2761d04f9d71dba059ab25374f3d791f60f6 Mon Sep 17 00:00:00 2001
From: gintsk <3540004+gintsk@users.noreply.github.com>
Date: Tue, 5 Mar 2024 10:56:24 +0200
Subject: [PATCH] Cleanup XML comments (#2007)
* Fix SA1629 for ArgumentNullException XML comments
* Fix "CA1200: Avoid using cref tags with a prefix" for ArgumentNullException
* Fix SA1629 and unify ArgumentNullException style
* Fix "SA1627 The documentation text within the 'exception' tag should not be empty"
* Unify ArgumentNullException XML comment style
* Fix SA1629 in remarks (are they even neccessary?)
* Unify ArgumentNullException XML comment style
* Fix SA1629 and unify XML comments in ArgumentNullException with two params; and fix wrongly referenced parameters in comments
* Fix SA1629 and unify comments in returns tag
Fix SA1629 in ArgumentOutOfRangeException XML comments and an summary tags
* Fix SA1614 "Element parameter documentation should have text"
* Fix SA1629 in param and returns tags
Fix SA1611 "The documentation for parameter 'key' is missing"
* Fix more SA1629; fixed some incorrect and added missing param comments
* PR comments (fix tag order, parameter name, remove duplicates)
---
.../ResiliencePipelineBuilderExtensions.cs | 4 +-
src/Polly/AsyncPolicy.ExecuteOverloads.cs | 64 ++---
.../AsyncPolicy.TResult.ExecuteOverloads.cs | 44 ++--
src/Polly/AsyncPolicy.TResult.cs | 2 +-
src/Polly/AsyncPolicy.cs | 2 +-
src/Polly/Bulkhead/AsyncBulkheadSyntax.cs | 4 +-
.../Bulkhead/AsyncBulkheadTResultSyntax.cs | 6 +-
src/Polly/Bulkhead/BulkheadSyntax.cs | 4 +-
src/Polly/Bulkhead/BulkheadTResultSyntax.cs | 4 +-
src/Polly/Caching/AsyncCacheSyntax.cs | 88 +++----
src/Polly/Caching/AsyncCacheTResultSyntax.cs | 226 +++++++++---------
.../Caching/AsyncSerializingCacheProvider.cs | 8 +-
src/Polly/Caching/CacheSyntax.cs | 100 ++++----
src/Polly/Caching/CacheTResultSyntax.cs | 226 +++++++++---------
src/Polly/Caching/SerializingCacheProvider.cs | 8 +-
.../AdvancedCircuitBreakerSyntax.cs | 98 ++++----
.../AdvancedCircuitBreakerTResultSyntax.cs | 98 ++++----
.../AsyncAdvancedCircuitBreakerSyntax.cs | 96 ++++----
...syncAdvancedCircuitBreakerTResultSyntax.cs | 96 ++++----
.../AsyncCircuitBreakerSyntax.cs | 36 +--
.../AsyncCircuitBreakerTResultSyntax.cs | 36 +--
.../CircuitBreaker/CircuitBreakerSyntax.cs | 40 ++--
.../CircuitBreakerTResultSyntax.cs | 40 ++--
src/Polly/DelegateResult.cs | 6 +-
src/Polly/Fallback/AsyncFallbackSyntax.cs | 32 +--
src/Polly/Fallback/FallbackSyntax.cs | 52 ++--
src/Polly/IAsyncPolicy.Extensions.cs | 2 +-
src/Polly/IAsyncPolicy.TResult.cs | 46 ++--
src/Polly/IAsyncPolicy.cs | 69 +++---
src/Polly/ISyncPolicy.Extensions.cs | 2 +-
src/Polly/ISyncPolicy.TResult.cs | 46 ++--
src/Polly/ISyncPolicy.cs | 72 +++---
src/Polly/IsPolicy.cs | 2 +-
src/Polly/Policy.ExecuteOverloads.cs | 76 +++---
src/Polly/Policy.HandleSyntax.cs | 2 +
src/Polly/Policy.TResult.ExecuteOverloads.cs | 46 ++--
src/Polly/Policy.TResult.cs | 2 +-
src/Polly/Policy.cs | 2 +-
src/Polly/PolicyResult.cs | 62 ++---
.../Registry/IConcurrentPolicyRegistry.cs | 26 +-
src/Polly/Registry/IPolicyRegistry.cs | 6 +-
src/Polly/Registry/IReadOnlyPolicyRegistry.cs | 11 +-
src/Polly/Registry/PolicyRegistry.cs | 26 +-
src/Polly/Retry/AsyncRetrySyntax.cs | 188 +++++----------
src/Polly/Retry/AsyncRetryTResultSyntax.cs | 180 +++++---------
src/Polly/Retry/RetrySyntax.cs | 104 +++-----
src/Polly/Retry/RetryTResultSyntax.cs | 112 +++------
src/Polly/Timeout/AsyncTimeoutSyntax.cs | 60 ++---
.../Timeout/AsyncTimeoutTResultSyntax.cs | 64 ++---
src/Polly/Timeout/TimeoutSyntax.cs | 64 ++---
src/Polly/Timeout/TimeoutTResultSyntax.cs | 64 ++---
src/Polly/Utilities/ExceptionExtensions.cs | 2 +-
src/Polly/Utilities/SystemClock.cs | 8 +-
53 files changed, 1260 insertions(+), 1504 deletions(-)
diff --git a/src/Polly.Core/ResiliencePipelineBuilderExtensions.cs b/src/Polly.Core/ResiliencePipelineBuilderExtensions.cs
index 14f2adfa92c..7b450ccabb9 100644
--- a/src/Polly.Core/ResiliencePipelineBuilderExtensions.cs
+++ b/src/Polly.Core/ResiliencePipelineBuilderExtensions.cs
@@ -16,7 +16,7 @@ public static class ResiliencePipelineBuilderExtensions
/// The builder instance.
/// The pipeline instance.
/// The same builder instance.
- /// Thrown when is null.
+ /// Thrown when is .
/// Thrown when this builder was already used to create a pipeline. The builder cannot be modified after it has been used.
[UnconditionalSuppressMessage(
"Trimming",
@@ -39,7 +39,7 @@ public static TBuilder AddPipeline(this TBuilder builder, ResiliencePi
/// The builder instance.
/// The pipeline instance.
/// The same builder instance.
- /// Thrown when is null.
+ /// Thrown when is .
/// Thrown when this builder was already used to create a strategy. The builder cannot be modified after it has been used.
[UnconditionalSuppressMessage(
"Trimming",
diff --git a/src/Polly/AsyncPolicy.ExecuteOverloads.cs b/src/Polly/AsyncPolicy.ExecuteOverloads.cs
index 2040b08e4b7..2bb15cd021a 100644
--- a/src/Polly/AsyncPolicy.ExecuteOverloads.cs
+++ b/src/Polly/AsyncPolicy.ExecuteOverloads.cs
@@ -77,7 +77,7 @@ public Task ExecuteAsync(Func action, CancellationToken
/// Arbitrary data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
/// Whether to continue on a captured synchronization context.
- /// contextData
+ /// Thrown when is .
[DebuggerStepThrough]
public Task ExecuteAsync(Func action, IDictionary contextData, CancellationToken cancellationToken, bool continueOnCapturedContext) =>
ExecuteAsync(action, new Context(contextData), cancellationToken, continueOnCapturedContext);
@@ -115,7 +115,7 @@ public async Task ExecuteAsync(Func action, Co
///
/// The type of the result.
/// The action to perform.
- /// The value returned by the action
+ /// The value returned by the action.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action) =>
ExecuteAsync((_, _) => action(), [], DefaultCancellationToken, DefaultContinueOnCapturedContext);
@@ -125,7 +125,7 @@ public Task ExecuteAsync(Func> action) =>
///
/// The action to perform.
/// Arbitrary data that is passed to the exception policy.
- /// The value returned by the action
+ /// The value returned by the action.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, IDictionary contextData) =>
ExecuteAsync((ctx, _) => action(ctx), new Context(contextData), DefaultCancellationToken, DefaultContinueOnCapturedContext);
@@ -136,7 +136,7 @@ public Task ExecuteAsync(Func> action,
/// The type of the result.
/// The action to perform.
/// Context data that is passed to the exception policy.
- /// The value returned by the action
+ /// The value returned by the action.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, Context context) =>
ExecuteAsync((ctx, _) => action(ctx), context, DefaultCancellationToken, DefaultContinueOnCapturedContext);
@@ -147,7 +147,7 @@ public Task ExecuteAsync(Func> action,
/// The type of the result.
/// The action to perform.
/// A cancellation token which can be used to cancel the action. When a retry policy is in use, also cancels any further retries.
- /// The value returned by the action
+ /// The value returned by the action.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, CancellationToken cancellationToken) =>
ExecuteAsync((_, ct) => action(ct), [], cancellationToken, DefaultContinueOnCapturedContext);
@@ -158,7 +158,7 @@ public Task ExecuteAsync(Func
/// The action to perform.
/// Arbitrary data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// The value returned by the action
+ /// The value returned by the action.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, IDictionary contextData, CancellationToken cancellationToken) =>
ExecuteAsync(action, new Context(contextData), cancellationToken, DefaultContinueOnCapturedContext);
@@ -170,7 +170,7 @@ public Task ExecuteAsync(FuncThe action to perform.
/// Context data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy is in use, also cancels any further retries.
- /// The value returned by the action
+ /// The value returned by the action.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, Context context, CancellationToken cancellationToken) =>
ExecuteAsync(action, context, cancellationToken, DefaultContinueOnCapturedContext);
@@ -182,7 +182,7 @@ public Task ExecuteAsync(FuncThe action to perform.
/// Whether to continue on a captured synchronization context.
/// A cancellation token which can be used to cancel the action. When a retry policy is in use, also cancels any further retries.
- /// The value returned by the action
+ /// The value returned by the action.
/// Please use asynchronous-defined policies when calling asynchronous ExecuteAsync (and similar) methods.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, CancellationToken cancellationToken, bool continueOnCapturedContext) =>
@@ -195,8 +195,8 @@ public Task ExecuteAsync(Func
/// Arbitrary data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
/// Whether to continue on a captured synchronization context.
- /// The value returned by the action
- /// contextData
+ /// The value returned by the action.
+ /// Thrown when is .
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, IDictionary contextData, CancellationToken cancellationToken, bool continueOnCapturedContext) =>
ExecuteAsync(action, new Context(contextData), cancellationToken, continueOnCapturedContext);
@@ -209,7 +209,7 @@ public Task ExecuteAsync(FuncContext data that is passed to the exception policy.
/// Whether to continue on a captured synchronization context.
/// A cancellation token which can be used to cancel the action. When a retry policy is in use, also cancels any further retries.
- /// The value returned by the action
+ /// The value returned by the action.
/// Please use asynchronous-defined policies when calling asynchronous ExecuteAsync (and similar) methods.
[DebuggerStepThrough]
public async Task ExecuteAsync(Func> action, Context context, CancellationToken cancellationToken, bool continueOnCapturedContext)
@@ -239,7 +239,7 @@ public async Task ExecuteAsync(Func
/// The action to perform.
- /// The captured result
+ /// The captured result.
[DebuggerStepThrough]
public Task ExecuteAndCaptureAsync(Func action) =>
ExecuteAndCaptureAsync((_, _) => action(), [], DefaultCancellationToken, DefaultContinueOnCapturedContext);
@@ -249,8 +249,8 @@ public Task ExecuteAndCaptureAsync(Func action) =>
///
/// The action to perform.
/// Arbitrary data that is passed to the exception policy.
- /// contextData
- /// The captured result
+ /// The captured result.
+ /// Thrown when is .
[DebuggerStepThrough]
public Task ExecuteAndCaptureAsync(Func action, IDictionary contextData) =>
ExecuteAndCaptureAsync((ctx, _) => action(ctx), new Context(contextData), DefaultCancellationToken, DefaultContinueOnCapturedContext);
@@ -260,7 +260,7 @@ public Task ExecuteAndCaptureAsync(Func action, IDi
///
/// The action to perform.
/// Context data that is passed to the exception policy.
- /// The captured result
+ /// The captured result.
[DebuggerStepThrough]
public Task ExecuteAndCaptureAsync(Func action, Context context) =>
ExecuteAndCaptureAsync((ctx, _) => action(ctx), context, DefaultCancellationToken, DefaultContinueOnCapturedContext);
@@ -280,8 +280,8 @@ public Task ExecuteAndCaptureAsync(Func a
/// The action to perform.
/// Arbitrary data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// contextData
- /// The captured result
+ /// The captured result.
+ /// Thrown when is .
[DebuggerStepThrough]
public Task ExecuteAndCaptureAsync(Func action, IDictionary contextData, CancellationToken cancellationToken) =>
ExecuteAndCaptureAsync(action, new Context(contextData), cancellationToken, DefaultContinueOnCapturedContext);
@@ -314,8 +314,8 @@ public Task ExecuteAndCaptureAsync(Func a
/// Arbitrary data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
/// Whether to continue on a captured synchronization context.
- /// contextData
- /// The captured result
+ /// The captured result.
+ /// Thrown when is .
[DebuggerStepThrough]
public Task ExecuteAndCaptureAsync(Func action, IDictionary contextData, CancellationToken cancellationToken, bool continueOnCapturedContext) =>
ExecuteAndCaptureAsync(action, new Context(contextData), cancellationToken, continueOnCapturedContext);
@@ -352,7 +352,7 @@ public async Task ExecuteAndCaptureAsync(Func
/// The type of the result.
/// The action to perform.
- /// The captured result
+ /// The captured result.
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action) =>
ExecuteAndCaptureAsync((_, _) => action(), [], DefaultCancellationToken, DefaultContinueOnCapturedContext);
@@ -363,8 +363,8 @@ public Task> ExecuteAndCaptureAsync(FuncThe type of the result.
/// The action to perform.
/// Arbitrary data that is passed to the exception policy.
- /// contextData
- /// The captured result
+ /// The captured result.
+ /// Thrown when is .
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, IDictionary contextData) =>
ExecuteAndCaptureAsync((ctx, _) => action(ctx), new Context(contextData), DefaultCancellationToken, DefaultContinueOnCapturedContext);
@@ -375,7 +375,7 @@ public Task> ExecuteAndCaptureAsync(FuncThe type of the result.
/// The action to perform.
/// Context data that is passed to the exception policy.
- /// The captured result
+ /// The captured result.
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, Context context) =>
ExecuteAndCaptureAsync((ctx, _) => action(ctx), context, DefaultCancellationToken, DefaultContinueOnCapturedContext);
@@ -386,7 +386,7 @@ public Task> ExecuteAndCaptureAsync(FuncThe type of the result.
/// The action to perform.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// The captured result
+ /// The captured result.
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, CancellationToken cancellationToken) =>
ExecuteAndCaptureAsync((_, ct) => action(ct), [], cancellationToken, DefaultContinueOnCapturedContext);
@@ -398,8 +398,8 @@ public Task> ExecuteAndCaptureAsync(FuncThe action to perform.
/// Arbitrary data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// contextData
- /// The captured result
+ /// The captured result.
+ /// Thrown when is .
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, IDictionary contextData, CancellationToken cancellationToken) =>
ExecuteAndCaptureAsync(action, new Context(contextData), cancellationToken, DefaultContinueOnCapturedContext);
@@ -409,9 +409,9 @@ public Task> ExecuteAndCaptureAsync(Func
/// The type of the result.
/// The action to perform.
- /// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
+ /// Context data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// The captured result
+ /// The captured result.
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, Context context, CancellationToken cancellationToken) =>
ExecuteAndCaptureAsync(action, context, cancellationToken, DefaultContinueOnCapturedContext);
@@ -423,7 +423,7 @@ public Task> ExecuteAndCaptureAsync(FuncThe action to perform.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
/// Whether to continue on a captured synchronization context.
- /// The captured result
+ /// The captured result.
/// Please use asynchronous-defined policies when calling asynchronous ExecuteAsync (and similar) methods.
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, CancellationToken cancellationToken, bool continueOnCapturedContext) =>
@@ -437,8 +437,8 @@ public Task> ExecuteAndCaptureAsync(FuncArbitrary data that is passed to the exception policy.
/// Whether to continue on a captured synchronization context.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// The captured result
- /// contextData
+ /// The captured result.
+ /// Thrown when is .
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, IDictionary contextData, CancellationToken cancellationToken, bool continueOnCapturedContext) =>
ExecuteAndCaptureAsync(action, new Context(contextData), cancellationToken, continueOnCapturedContext);
@@ -451,7 +451,7 @@ public Task> ExecuteAndCaptureAsync(FuncContext data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
/// Whether to continue on a captured synchronization context.
- /// The captured result
+ /// The captured result.
/// Please use asynchronous-defined policies when calling asynchronous ExecuteAsync (and similar) methods.
[DebuggerStepThrough]
public async Task> ExecuteAndCaptureAsync(Func> action, Context context, CancellationToken cancellationToken, bool continueOnCapturedContext)
diff --git a/src/Polly/AsyncPolicy.TResult.ExecuteOverloads.cs b/src/Polly/AsyncPolicy.TResult.ExecuteOverloads.cs
index fedc85c45a4..8941c58fa76 100644
--- a/src/Polly/AsyncPolicy.TResult.ExecuteOverloads.cs
+++ b/src/Polly/AsyncPolicy.TResult.ExecuteOverloads.cs
@@ -8,7 +8,7 @@ public abstract partial class AsyncPolicy : IAsyncPolicy
/// Executes the specified asynchronous action within the policy and returns the result.
///
/// The action to perform.
- /// The value returned by the action
+ /// The value returned by the action.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action) =>
ExecuteAsync((_, _) => action(), [], CancellationToken.None, DefaultContinueOnCapturedContext);
@@ -18,7 +18,7 @@ public Task ExecuteAsync(Func> action) =>
///
/// The action to perform.
/// Arbitrary data that is passed to the exception policy.
- /// The value returned by the action
+ /// The value returned by the action.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, IDictionary contextData) =>
ExecuteAsync((ctx, _) => action(ctx), new Context(contextData), CancellationToken.None, DefaultContinueOnCapturedContext);
@@ -28,7 +28,7 @@ public Task ExecuteAsync(Func> action, IDictiona
///
/// The action to perform.
/// Context data that is passed to the exception policy.
- /// The value returned by the action
+ /// The value returned by the action.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, Context context) =>
ExecuteAsync((ctx, _) => action(ctx), context, CancellationToken.None, DefaultContinueOnCapturedContext);
@@ -38,7 +38,7 @@ public Task ExecuteAsync(Func> action, Context c
///
/// The action to perform.
/// A cancellation token which can be used to cancel the action. When a retry policy is in use, also cancels any further retries.
- /// The value returned by the action
+ /// The value returned by the action.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, CancellationToken cancellationToken) =>
ExecuteAsync((_, ct) => action(ct), [], cancellationToken, DefaultContinueOnCapturedContext);
@@ -49,7 +49,7 @@ public Task ExecuteAsync(Func> action,
/// The action to perform.
/// Whether to continue on a captured synchronization context.
/// A cancellation token which can be used to cancel the action. When a retry policy is in use, also cancels any further retries.
- /// The value returned by the action
+ /// The value returned by the action.
/// Please use asynchronous-defined policies when calling asynchronous ExecuteAsync (and similar) methods.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, CancellationToken cancellationToken, bool continueOnCapturedContext) =>
@@ -61,7 +61,7 @@ public Task ExecuteAsync(Func> action,
/// The action to perform.
/// Arbitrary data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// The value returned by the action
+ /// The value returned by the action.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, IDictionary contextData, CancellationToken cancellationToken) =>
ExecuteAsync(action, new Context(contextData), cancellationToken, DefaultContinueOnCapturedContext);
@@ -72,7 +72,7 @@ public Task ExecuteAsync(Func
/// The action to perform.
/// Context data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy is in use, also cancels any further retries.
- /// The value returned by the action
+ /// The value returned by the action.
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, Context context, CancellationToken cancellationToken) =>
ExecuteAsync(action, context, cancellationToken, DefaultContinueOnCapturedContext);
@@ -84,8 +84,8 @@ public Task ExecuteAsync(Func
/// Arbitrary data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
/// Whether to continue on a captured synchronization context.
- /// The value returned by the action
- /// contextData
+ /// The value returned by the action.
+ /// Thrown when is .
[DebuggerStepThrough]
public Task ExecuteAsync(Func> action, IDictionary contextData, CancellationToken cancellationToken, bool continueOnCapturedContext) =>
ExecuteAsync(action, new Context(contextData), cancellationToken, continueOnCapturedContext);
@@ -97,7 +97,7 @@ public Task ExecuteAsync(Func
/// Context data that is passed to the exception policy.
/// Whether to continue on a captured synchronization context.
/// A cancellation token which can be used to cancel the action. When a retry policy is in use, also cancels any further retries.
- /// The value returned by the action
+ /// The value returned by the action.
/// Please use asynchronous-defined policies when calling asynchronous ExecuteAsync (and similar) methods.
[DebuggerStepThrough]
public async Task ExecuteAsync(Func> action, Context context, CancellationToken cancellationToken, bool continueOnCapturedContext)
@@ -125,7 +125,7 @@ public async Task ExecuteAsync(Func
/// The action to perform.
- /// The captured result
+ /// The captured result.
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action) =>
ExecuteAndCaptureAsync((_, _) => action(), [], CancellationToken.None, DefaultContinueOnCapturedContext);
@@ -135,8 +135,8 @@ public Task> ExecuteAndCaptureAsync(Func> ac
///
/// The action to perform.
/// Arbitrary data that is passed to the exception policy.
- /// contextData
- /// The captured result
+ /// The captured result.
+ /// Thrown when is .
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, IDictionary contextData) =>
ExecuteAndCaptureAsync((ctx, _) => action(ctx), new Context(contextData), CancellationToken.None, DefaultContinueOnCapturedContext);
@@ -146,7 +146,7 @@ public Task> ExecuteAndCaptureAsync(Func
/// The action to perform.
/// Context data that is passed to the exception policy.
- /// The captured result
+ /// The captured result.
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, Context context) =>
ExecuteAndCaptureAsync((ctx, _) => action(ctx), context, CancellationToken.None, DefaultContinueOnCapturedContext);
@@ -156,7 +156,7 @@ public Task> ExecuteAndCaptureAsync(Func
/// The action to perform.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// The captured result
+ /// The captured result.
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, CancellationToken cancellationToken) =>
ExecuteAndCaptureAsync((_, ct) => action(ct), [], cancellationToken, DefaultContinueOnCapturedContext);
@@ -167,7 +167,7 @@ public Task> ExecuteAndCaptureAsync(FuncThe action to perform.
/// Whether to continue on a captured synchronization context.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// The captured result
+ /// The captured result.
/// Please use asynchronous-defined policies when calling asynchronous ExecuteAsync (and similar) methods.
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, CancellationToken cancellationToken, bool continueOnCapturedContext) =>
@@ -179,8 +179,8 @@ public Task> ExecuteAndCaptureAsync(FuncThe action to perform.
/// Arbitrary data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// contextData
- /// The captured result
+ /// The captured result.
+ /// Thrown when is .
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, IDictionary contextData, CancellationToken cancellationToken) =>
ExecuteAndCaptureAsync(action, new Context(contextData), cancellationToken, DefaultContinueOnCapturedContext);
@@ -191,7 +191,7 @@ public Task> ExecuteAndCaptureAsync(FuncThe action to perform.
/// Context data that is passed to the exception policy.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// The captured result
+ /// The captured result.
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, Context context, CancellationToken cancellationToken) =>
ExecuteAndCaptureAsync(action, context, cancellationToken, DefaultContinueOnCapturedContext);
@@ -203,8 +203,8 @@ public Task> ExecuteAndCaptureAsync(FuncArbitrary data that is passed to the exception policy.
/// Whether to continue on a captured synchronization context.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// The captured result
- /// contextData
+ /// The captured result.
+ /// Thrown when is .
[DebuggerStepThrough]
public Task> ExecuteAndCaptureAsync(Func> action, IDictionary contextData, CancellationToken cancellationToken, bool continueOnCapturedContext) =>
ExecuteAndCaptureAsync(action, new Context(contextData), cancellationToken, continueOnCapturedContext);
@@ -216,7 +216,7 @@ public Task> ExecuteAndCaptureAsync(FuncContext data that is passed to the exception policy.
/// Whether to continue on a captured synchronization context.
/// A cancellation token which can be used to cancel the action. When a retry policy in use, also cancels any further retries.
- /// The captured result
+ /// The captured result.
/// Please use asynchronous-defined policies when calling asynchronous ExecuteAsync (and similar) methods.
[DebuggerStepThrough]
public async Task> ExecuteAndCaptureAsync(Func> action, Context context, CancellationToken cancellationToken, bool continueOnCapturedContext)
diff --git a/src/Polly/AsyncPolicy.TResult.cs b/src/Polly/AsyncPolicy.TResult.cs
index e6c8898a168..74796e79f08 100644
--- a/src/Polly/AsyncPolicy.TResult.cs
+++ b/src/Polly/AsyncPolicy.TResult.cs
@@ -2,7 +2,7 @@
namespace Polly;
///
-/// Transient exception handling policies that can be applied to asynchronous delegates
+/// Transient exception handling policies that can be applied to asynchronous delegates.
///
/// The return type of delegates which may be executed through the policy.
public abstract partial class AsyncPolicy : PolicyBase
diff --git a/src/Polly/AsyncPolicy.cs b/src/Polly/AsyncPolicy.cs
index e2a37c717c3..46fbd60f15d 100644
--- a/src/Polly/AsyncPolicy.cs
+++ b/src/Polly/AsyncPolicy.cs
@@ -2,7 +2,7 @@
namespace Polly;
///
-/// Transient exception handling policies that can be applied to asynchronous delegates
+/// Transient exception handling policies that can be applied to asynchronous delegates.
///
public abstract partial class AsyncPolicy
{
diff --git a/src/Polly/Bulkhead/AsyncBulkheadSyntax.cs b/src/Polly/Bulkhead/AsyncBulkheadSyntax.cs
index 9e01a11930b..80cfc1459a9 100644
--- a/src/Polly/Bulkhead/AsyncBulkheadSyntax.cs
+++ b/src/Polly/Bulkhead/AsyncBulkheadSyntax.cs
@@ -23,7 +23,7 @@ public static AsyncBulkheadPolicy BulkheadAsync(int maxParallelization)
/// An action to call asynchronously, if the bulkhead rejects execution due to oversubscription.
/// The policy instance.
/// maxParallelization;Value must be greater than zero.
- /// onBulkheadRejectedAsync
+ /// Thrown when is .
/// The policy instance.
public static AsyncBulkheadPolicy BulkheadAsync(int maxParallelization, Func onBulkheadRejectedAsync) =>
BulkheadAsync(maxParallelization, 0, onBulkheadRejectedAsync);
@@ -53,7 +53,7 @@ public static AsyncBulkheadPolicy BulkheadAsync(int maxParallelization, int maxQ
/// The policy instance.
/// maxParallelization;Value must be greater than zero.
/// maxQueuingActions;Value must be greater than or equal to zero.
- /// onBulkheadRejectedAsync
+ /// Thrown when is .
public static AsyncBulkheadPolicy BulkheadAsync(
int maxParallelization,
int maxQueuingActions,
diff --git a/src/Polly/Bulkhead/AsyncBulkheadTResultSyntax.cs b/src/Polly/Bulkhead/AsyncBulkheadTResultSyntax.cs
index 77990236f53..721cb65923d 100644
--- a/src/Polly/Bulkhead/AsyncBulkheadTResultSyntax.cs
+++ b/src/Polly/Bulkhead/AsyncBulkheadTResultSyntax.cs
@@ -22,7 +22,7 @@ public static AsyncBulkheadPolicy BulkheadAsync(int maxParalle
/// The maximum number of concurrent actions that may be executing through the policy.
/// An action to call asynchronously, if the bulkhead rejects execution due to oversubscription.
/// maxParallelization;Value must be greater than zero.
- /// onBulkheadRejectedAsync
+ /// Thrown when is .
/// The policy instance.
public static AsyncBulkheadPolicy BulkheadAsync(int maxParallelization, Func onBulkheadRejectedAsync) =>
BulkheadAsync(maxParallelization, 0, onBulkheadRejectedAsync);
@@ -36,7 +36,7 @@ public static AsyncBulkheadPolicy BulkheadAsync(int maxParalle
/// The policy instance.
/// maxParallelization;Value must be greater than zero.
/// maxQueuingActions;Value must be greater than or equal to zero.
- /// onBulkheadRejectedAsync
+ /// Thrown when is .
public static AsyncBulkheadPolicy BulkheadAsync(int maxParallelization, int maxQueuingActions)
{
Func doNothingAsync = _ => TaskHelper.EmptyTask;
@@ -53,7 +53,7 @@ public static AsyncBulkheadPolicy BulkheadAsync(int maxParalle
/// The policy instance.
/// maxParallelization;Value must be greater than zero.
/// maxQueuingActions;Value must be greater than or equal to zero.
- /// onBulkheadRejectedAsync
+ /// Thrown when is .
public static AsyncBulkheadPolicy BulkheadAsync(int maxParallelization, int maxQueuingActions, Func onBulkheadRejectedAsync)
{
if (maxParallelization <= 0)
diff --git a/src/Polly/Bulkhead/BulkheadSyntax.cs b/src/Polly/Bulkhead/BulkheadSyntax.cs
index 2b15e6c757b..c841d9d8ba4 100644
--- a/src/Polly/Bulkhead/BulkheadSyntax.cs
+++ b/src/Polly/Bulkhead/BulkheadSyntax.cs
@@ -23,7 +23,7 @@ public static BulkheadPolicy Bulkhead(int maxParallelization)
/// The maximum number of concurrent actions that may be executing through the policy.
/// An action to call, if the bulkhead rejects execution due to oversubscription.
/// maxParallelization;Value must be greater than zero.
- /// onBulkheadRejected
+ /// Thrown when is .
/// The policy instance.
public static BulkheadPolicy Bulkhead(int maxParallelization, Action onBulkheadRejected) =>
Bulkhead(maxParallelization, 0, onBulkheadRejected);
@@ -53,7 +53,7 @@ public static BulkheadPolicy Bulkhead(int maxParallelization, int maxQueuingActi
/// The policy instance.
/// maxParallelization;Value must be greater than zero.
/// maxParallelization;Value must be greater than zero.
- /// onBulkheadRejected
+ /// Thrown when is .
public static BulkheadPolicy Bulkhead(int maxParallelization, int maxQueuingActions, Action onBulkheadRejected)
{
if (maxParallelization <= 0)
diff --git a/src/Polly/Bulkhead/BulkheadTResultSyntax.cs b/src/Polly/Bulkhead/BulkheadTResultSyntax.cs
index 55445998e36..d5918091faf 100644
--- a/src/Polly/Bulkhead/BulkheadTResultSyntax.cs
+++ b/src/Polly/Bulkhead/BulkheadTResultSyntax.cs
@@ -23,7 +23,7 @@ public static BulkheadPolicy Bulkhead(int maxParallelization)
/// The maximum number of concurrent actions that may be executing through the policy.
/// An action to call, if the bulkhead rejects execution due to oversubscription.
/// maxParallelization;Value must be greater than zero.
- /// onBulkheadRejected
+ /// Thrown when is .
/// The policy instance.
public static BulkheadPolicy Bulkhead(int maxParallelization, Action onBulkheadRejected) =>
Bulkhead(maxParallelization, 0, onBulkheadRejected);
@@ -53,7 +53,7 @@ public static BulkheadPolicy Bulkhead(int maxParallelization,
/// The policy instance.
/// maxParallelization;Value must be greater than zero.
/// maxQueuingActions;Value must be greater than or equal to zero.
- /// onBulkheadRejected
+ /// Thrown when is .
public static BulkheadPolicy Bulkhead(int maxParallelization, int maxQueuingActions, Action onBulkheadRejected)
{
if (maxParallelization <= 0)
diff --git a/src/Polly/Caching/AsyncCacheSyntax.cs b/src/Polly/Caching/AsyncCacheSyntax.cs
index b7a5702d117..3467f22d1ef 100644
--- a/src/Polly/Caching/AsyncCacheSyntax.cs
+++ b/src/Polly/Caching/AsyncCacheSyntax.cs
@@ -13,7 +13,7 @@ public partial class Policy
/// Duration (ttl) for which to cache values.
/// Delegate to call if an exception is thrown when attempting to get a value from or put a value into the cache, passing the execution context, the cache key, and the exception.
/// The policy instance.
- /// cacheProvider
+ /// Thrown when is .
public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, TimeSpan ttl, Action? onCacheError = null) =>
CacheAsync(cacheProvider, new RelativeTtl(ttl), DefaultCacheKeyStrategy.Instance.GetCacheKey, onCacheError);
@@ -27,8 +27,8 @@ public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, Tim
/// A strategy for specifying ttl for values to be cached.
/// Delegate to call if an exception is thrown when attempting to get a value from or put a value into the cache, passing the execution context, the cache key, and the exception.
/// The policy instance.
- /// cacheProvider
- /// ttlStrategy
+ /// Thrown when is .
+ /// Thrown when is .
public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, ITtlStrategy ttlStrategy, Action? onCacheError = null) =>
CacheAsync(cacheProvider, ttlStrategy, DefaultCacheKeyStrategy.Instance.GetCacheKey, onCacheError);
@@ -43,8 +43,8 @@ public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, ITt
/// The cache key strategy.
/// Delegate to call if an exception is thrown when attempting to get a value from or put a value into the cache, passing the execution context, the cache key, and the exception.
/// The policy instance.
- /// cacheProvider
- /// cacheKeyStrategy
+ /// Thrown when is .
+ /// Thrown when is .
public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, TimeSpan ttl, ICacheKeyStrategy cacheKeyStrategy, Action? onCacheError = null) =>
CacheAsync(cacheProvider, new RelativeTtl(ttl), cacheKeyStrategy.GetCacheKey, onCacheError);
@@ -59,9 +59,9 @@ public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, Tim
/// The cache key strategy.
/// Delegate to call if an exception is thrown when attempting to get a value from or put a value into the cache, passing the execution context, the cache key, and the exception.
/// The policy instance.
- /// cacheProvider
- /// ttlStrategy
- /// cacheKeyStrategy
+ /// Thrown when is .
+ /// Thrown when is .
+ /// Thrown when is .
public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, ITtlStrategy ttlStrategy, ICacheKeyStrategy cacheKeyStrategy, Action? onCacheError = null)
{
if (cacheProvider == null)
@@ -87,8 +87,8 @@ public static AsyncCachePolicy CacheAsync(IAsyncCacheProvider cacheProvider, ITt
/// The cache key strategy.
/// Delegate to call if an exception is thrown when attempting to get a value from or put a value into the cache, passing the execution context, the cache key, and the exception.
/// The policy instance.
- /// cacheProvider
- /// cacheKeyStrategy
+ /// Thrown when