Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading message "cannot find" #42

Open
probonopd opened this issue Jul 26, 2019 · 3 comments
Open

Misleading message "cannot find" #42

probonopd opened this issue Jul 26, 2019 · 3 comments

Comments

@probonopd
Copy link
Member

me@host:~$ Downloads/zsync2-137-bacc238-x86_64.AppImage --seed-file=/isodevice/boot/iso/custom-desktop-amd64.iso  https://github.com/probonopd/meilix/releases/download/continuous/custom-desktop-amd64.iso.zsync
zsync2 version 2.0.0-alpha-1 (commit bacc238), build 137 built on 2019-01-04 05:09:05 UTC
Checking for changes...
Cannot find file custom-desktop-amd64.iso, triggering full download
Target file: /home/me/custom-desktop-amd64.iso
Reading seed file: /isodevice/boot/iso/custom-desktop-amd64.iso

Here the message

Cannot find file custom-desktop-amd64.iso, triggering full download

is misleading. It took me a while to understand that after this message appears it still finds the seed file:

Reading seed file: /isodevice/boot/iso/custom-desktop-amd64.iso

Hence, the first message should be changed to say "Could not find pre-existing original..." or something like that. Or the message should not appear at all if at least one seed file is given.

@TheAssassin
Copy link
Member

Hence, the first message should be changed to say "Could not find pre-existing original..." or something like that. Or the message should not appear at all if at least one seed file is given.

Logging happens sequentially. Here, an "expected" seed file (read from the .zsync file) could not be found, since it's just a filename and you're in some other directory. Later on, your custom provided seed file is then taken into account. That's completely fine.

The only thing to do here is improve/refine the first log message, i.e., add from .zsync file or something like that to clarify where that filename has come from. Obviously it's not referring to the --seed-file one, if it were, it'd have printed the full filename.

@probonopd
Copy link
Member Author

probonopd commented Jul 27, 2019

Obviously it's not referring to the --seed-file one

May be obvious to its developer, but not to a mere user like me... your explanation makes sense (exactly what I had figured out) but still initially I was puzzled what was going on. So yes, a clearer message would be good (e.g., "Pre-existing file <...> not found at <...>").

@probonopd
Copy link
Member Author

Cannot find file neon-developer-current.iso, **triggering full download**
Found SHA256 digest: 4f85711da41c8fbceea5997e642339a03c230ff54900c933f26d7a319d44c076
Verified instance digest of redirected .zsync response
Target file: /isodevice/boot/iso/neon-developer-current.iso
Reading seed file: neon-devedition-gitunstable-20181118-2057-amd64.iso

The "triggering full download" always makes me press Ctrl-C at that point. It is not only misleading but plain wrong, as one can see a few lines further down below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants