Characters appearing at the end of some commands

[Arcensoth]

[Arcensoth]

Cannot reproduce. Pinging @misode for more info...

[misode]

I have a Windows OS. The issue appears for me in some mcfunction files on the GitHub site.
example file that doesn't reproduce this issue
example file that does reproduce the issue

[Arcensoth]

At some point - probably as a side-effect of an earlier fix - I must have fixed the trailing arguments being highlighted as errors, but the ^M is a slightly different red and I don't think it's a problem with the syntax highlighter. Here's some research:

• ^M characters when saving plain text atom/atom#3105 (comment)
• https://stackoverflow.com/questions/1822849/what-are-these-ms-that-keep-showing-up-in-my-files-in-emacs
• https://superuser.com/questions/1217622/how-can-i-remove-the-m-from-my-file-in-sublime-text-3

It looks like people might be committing files with CRLF and then GitHub decides to force-highlight the carriage returns.

We'll see how the next Linguist update handles the affected files and re-open if it's clear there's more to be done here.

[Arcensoth]

An update, for posterity:

GitHub Linguist has been updated, and is now running v0.13.0 of language-mcfunction.

As expected, the trailing arguments are being highlighted properly but the ^M characters remain:

https://github.com/Gamemode4Dev/GM4_Datapacks/blob/master/gm4_phantom_scarecrows/data/phantom_scarecrows/functions/main.mcfunction#L2

Like I mentioned in my last comment, I'm not confident that this is a problem with the grammar itself but instead that people are committing carriage returns to mcfunction files. It may be the grammar's fault that these characters are being highlighted, but after some testing (via github-lightshow) I was unable to remove these characters by any means.

Until I have more definitive information about the problem and/or people reporting it, I'm going to work under the assumption that this is out of the grammar's control.

[Arcensoth]

Re-opening because this is still a problem and it's probably something that can be fixed with some effort.

[Arcensoth]

I should really create a new issue for this.

[Arcensoth]

(See #32 for a new report focused on the line-endings specifically.)