Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person object #87

Open
shahab-a-k opened this issue Aug 24, 2020 · 3 comments
Open

Person object #87

shahab-a-k opened this issue Aug 24, 2020 · 3 comments

Comments

@shahab-a-k
Copy link
Contributor

Hello Team,

Is any update on the way to include person object? in context.system property?

@ElvenMonky
Copy link
Collaborator

ElvenMonky commented Aug 25, 2020

Hi @shahab-a-k ,

Thanks for the PRs (#88 and #89)! Both PR look good and change doesn't seem to be breaking.
Let me see if there were any other fields introduced since library was last published... Ok, I don't see any https://developer.amazon.com/en-US/docs/alexa/custom-skills/request-and-response-json-reference.html#request-body-syntax

@ElvenMonky
Copy link
Collaborator

Ok, I merged both PRs and now the question is: do you want us to release new nuget version with this changes?
I assume it would be minor version incremented, as it affects request body format and some skills might not expect this change.

@shahab-a-k
Copy link
Contributor Author

It's upto you, currently I'm working more in depth with it. I'm not sure, but I might add a few more enhancements and apply a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants