Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logger? #149

Open
2 tasks
Ark2000 opened this issue Nov 25, 2023 · 3 comments
Open
2 tasks

Remove logger? #149

Ark2000 opened this issue Nov 25, 2023 · 3 comments
Labels
Feature✨ New feature or request Improvement✒

Comments

@Ark2000
Copy link
Owner

Ark2000 commented Nov 25, 2023

the native logger module should be a part of dev console.

TODO:

  • Improve the dev console output performance to support millions of lines of output
  • a filter mechanism
@Ark2000 Ark2000 added Feature✨ New feature or request Improvement✒ labels Nov 25, 2023
@Ark2000 Ark2000 changed the title Remove native logger Remove native logger? Nov 25, 2023
@Ark2000 Ark2000 changed the title Remove native logger? Remove logger? Nov 25, 2023
@Ark2000
Copy link
Owner Author

Ark2000 commented Nov 26, 2023

A new text area node composed of two RichTextLabel nodes will be introduced to cap lines of content.

it is like, an infinite scroll game.

specifically, the first buffer will be cleared and sent to the last when the last buffer is full.

with buffers, we can constanly output lots of stuff while keeping a smooth experience.

@toolness
Copy link

toolness commented Jul 6, 2024

Hi! I am really liking Panku Console but the fact that the logger defaults to "Always show" is making things a bit frustrating:

  1. I didn't like this behavior because I wanted my alpha testers to be able to access the console if needed, so I didn't excise it from my build. This behavior is obviously not great for an alpha tester because it clobbers their gameplay with all the logging junk.

  2. I did set a custom Panku config that set the default to "Show if shell visible", BUT I found out after distributing my build that the config file wasn't actually included in the export, so it couldn't actually find it, so it defaulted to "always show" and wrote the configuration to the user's user data dir.

  3. Now I have to give my users instructions on how to go through a bunch of menu options to change the default to "Show if shell visible". (Side note: it would be really cool if I could tell them to download a new build and click an easily-accessible "reset to defaults" button or run a similar command to fix things, as having to write and follow instructions on going through menu hierarchies isn't fun.)

Anyways, this is all to say: maybe I'm in the minority, but I feel like defaulting the logger to "Show if shell visible" would be a much better default.

Regardless, thanks for making this great tool, overall I'm very happy with it!

@worron
Copy link
Collaborator

worron commented Jul 8, 2024

I did set a custom Panku config that set the default to "Show if shell visible", BUT I found out after distributing my build that the config file wasn't actually included in the export

This is confusing part, your custom config file should work in exported build if everything configured right.
Please take a look at #175 and #179 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature✨ New feature or request Improvement✒
Projects
None yet
Development

No branches or pull requests

3 participants