Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test workflow #32

Open
Ark2000 opened this issue Dec 7, 2022 · 3 comments
Open

Add unit test workflow #32

Ark2000 opened this issue Dec 7, 2022 · 3 comments
Assignees
Labels
Help Wanted ❕ Extra attention is needed Improvement✒
Milestone

Comments

@Ark2000
Copy link
Owner

Ark2000 commented Dec 7, 2022

By utilizing this great project: https://github.com/bitwes/Gut

A good reference: https://github.com/bitbrain/beehave/blob/godot-4.x/.github/workflows/unit-tests.yml

@Ark2000 Ark2000 added this to the v2.0 milestone Dec 7, 2022
@Ark2000 Ark2000 self-assigned this Jan 3, 2023
@Ark2000 Ark2000 added Help Wanted ❕ Extra attention is needed Critical 💩 and removed Critical 💩 labels Mar 16, 2023
@Ark2000 Ark2000 modified the milestones: v2.0, v1.5 Mar 16, 2023
@Ark2000 Ark2000 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2023
@Ark2000 Ark2000 reopened this Jul 22, 2023
@Ark2000 Ark2000 changed the title Add unit test Add unit test workflow Jul 22, 2023
@Eggbertx
Copy link
Contributor

I got GUT working and created a simple input test, but Godot isn't playing nicely with the GitHub workflow VM.
https://github.com/Eggbertx/PankuConsole/actions/runs/6839651321/job/18598061573#step:4:19
The command works fine and has a 0 exit code when I run it on my own computer, but it's crashing when run in the workflow. I've tried with xvfb-run (a virtual framebuffer X server) and without it, using Godot's --headless command line argument.
Both result in it crashing with "Debugger Break, Reason: 'Parser Error: Could not find type "PankuLynxWindowsManager" in the current scope.'"

@Ark2000
Copy link
Owner Author

Ark2000 commented Nov 12, 2023

I got GUT working and created a simple input test, but Godot isn't playing nicely with the GitHub workflow VM. https://github.com/Eggbertx/PankuConsole/actions/runs/6839651321/job/18598061573#step:4:19 The command works fine and has a 0 exit code when I run it on my own computer, but it's crashing when run in the workflow. I've tried with xvfb-run (a virtual framebuffer X server) and without it, using Godot's --headless command line argument. Both result in it crashing with "Debugger Break, Reason: 'Parser Error: Could not find type "PankuLynxWindowsManager" in the current scope.'"

bitbrain is using gdUnit4 as beehave's test tool, maybe gdUnit4 is a better option other than GUT

@Eggbertx
Copy link
Contributor

Alright, it works with gdUnit4. Though at the moment the only thing that's being tested is that the module manager is initialized and working correctly, and that the shell opens when the ~ key is "pressed" and closes when it's "pressed" again.

@Ark2000 Ark2000 modified the milestones: v1.5, v2.0, v1.8 Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted ❕ Extra attention is needed Improvement✒
Projects
None yet
Development

No branches or pull requests

2 participants