From 6bba57eb2800d70b6bf593ef892b9ab17519cbb1 Mon Sep 17 00:00:00 2001 From: Micah Wylde Date: Mon, 13 Jan 2025 14:43:35 -0800 Subject: [PATCH] clippy --- crates/arroyo-connectors/src/redis/mod.rs | 12 +++++------- crates/arroyo-rpc/src/api_types/connections.rs | 1 + 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/crates/arroyo-connectors/src/redis/mod.rs b/crates/arroyo-connectors/src/redis/mod.rs index 2f84469e4..eba81d528 100644 --- a/crates/arroyo-connectors/src/redis/mod.rs +++ b/crates/arroyo-connectors/src/redis/mod.rs @@ -303,13 +303,11 @@ impl Connector for RedisConnector { "lookup" => { // for look-up tables, we require that there's a primary key metadata field for f in &schema.fields { - if schema.primary_keys.contains(&f.field_name) { - if f.metadata_key.as_ref().map(|k| k != "key").unwrap_or(true) { - bail!( - "Redis lookup tables must have a PRIMARY KEY field defined as \ - `field_name TEXT GENERATED ALWAYS AS (metadata('key')) STORED`" - ); - } + if schema.primary_keys.contains(&f.field_name) && f.metadata_key.as_ref().map(|k| k != "key").unwrap_or(true) { + bail!( + "Redis lookup tables must have a PRIMARY KEY field defined as \ + `field_name TEXT GENERATED ALWAYS AS (metadata('key')) STORED`" + ); } } diff --git a/crates/arroyo-rpc/src/api_types/connections.rs b/crates/arroyo-rpc/src/api_types/connections.rs index 63a30336a..5dfbd3429 100644 --- a/crates/arroyo-rpc/src/api_types/connections.rs +++ b/crates/arroyo-rpc/src/api_types/connections.rs @@ -257,6 +257,7 @@ pub struct ConnectionSchema { } impl ConnectionSchema { + #[allow(clippy::too_many_arguments)] pub fn try_new( format: Option, bad_data: Option,