From 7762f0f0bf0675b6ca2d98884a89fc33ce8a2e54 Mon Sep 17 00:00:00 2001
From: OnnoEbbens <onnoebbens@gmail.com>
Date: Wed, 9 Oct 2024 14:14:20 +0200
Subject: [PATCH] Release 0.12.5 (bug fix) (#246)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* allow get_stations with meteo_var == slice(None)

* only filter stations if start/end is provided

* ensure current station is in dataframe so nearest station can be determined

* fix for knmi precipitation data station attribute is sometimes a series with duplicate entries #241 (#242)

* reshuffle a bit

* ruff

* up version for minor release

* version bump

* fix bug in fill_missing_obs

* version bump

* ruff

* ruff

---------

Co-authored-by: Davíd Brakenhoff <d.brakenhoff@artesia-water.nl>
---
 hydropandas/io/knmi.py | 7 +++++--
 hydropandas/version.py | 2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/hydropandas/io/knmi.py b/hydropandas/io/knmi.py
index ecbc3cea..7fa48298 100644
--- a/hydropandas/io/knmi.py
+++ b/hydropandas/io/knmi.py
@@ -249,8 +249,10 @@ def _get_default_settings(settings=None) -> Dict[str, Any]:
 
     if "fill_missing_obs" in settings.keys():
         if "raise_exceptions" in settings.keys():
-            logger.debug("set raise_exceptions=False because fill_missing_obs is True")
             if settings["fill_missing_obs"] and settings["raise_exceptions"]:
+                logger.debug(
+                    "set raise_exceptions=False because fill_missing_obs is True"
+                )
                 settings["raise_exceptions"] = False
         else:
             settings["raise_exceptions"] = False
@@ -611,6 +613,7 @@ def fill_missing_measurements(
             meteo_var=meteo_var,
             start=start,
             end=end,
+            stations=stations,
             ignore=ignore,
         )
 
@@ -1457,7 +1460,7 @@ def get_nearest_station_df(
     if stations is None:
         stations = get_stations(meteo_var=meteo_var, start=start, end=end)
     if ignore is not None:
-        stations.drop(ignore, inplace=True)
+        stations = stations.drop(ignore)
         if stations.empty:
             return None
 
diff --git a/hydropandas/version.py b/hydropandas/version.py
index 841fa6a4..5e3bf002 100644
--- a/hydropandas/version.py
+++ b/hydropandas/version.py
@@ -1,7 +1,7 @@
 from importlib import metadata
 from sys import version as os_version
 
-__version__ = "0.12.4"
+__version__ = "0.12.5"
 
 
 def show_versions():