Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time controls is not working as expected when the charts tab is visible #107

Open
adam-collins opened this issue Sep 24, 2024 · 2 comments
Assignees
Milestone

Comments

@adam-collins
Copy link
Contributor

The "Explore by species" tab, and map interaction, including time controls, appear to be working except for

  • Selecting a group, e.g. "Birds", then clicking the time control "play" repeatedly toggles the group expansion between open and closed states.
  • Selecting a subgroup, e.g. "Doves" under "Birds", does not give any indication that "Doves" is selected. Combined with time control "play", it is unclear if the species column contains all "Birds" (the open group) or the "Doves" selection (the actual filter applied).
  • Selecting a species in the species column is a little unclear that it is selected, except for the two buttons beneath the selected species. Clicking the time control "play" and it is not as clear as I would prefer that the species selection no longer applies.

The "Explore by taxonomy" tab

  • There is insufficient "reset" taking place when clicking between the tabs.
  • Both the "play by decade" and manually setting the time control results in no chart displayed and no date filter applied to points on the map.
  • Clicking on the chart to "drill down" does update the map.
  • Clicking on the "Previous rank" button below the chart, after "drill down", does update the map.
  • The text on the "View records for ..." button appears correct after "drill down" and clicking on "Previous rank".
  • The biocache-hub page opened after clicking "View records for ..." button appears correct after "drill down" and clicking on "Previous rank".
  • Clicking on the "reset" button in the time controls can result in incorrect labelling of "View records for ...", does not correctly reset the "Previous rank" button below the chart, and 2 resets are required to reset the chart.
  • The "Click a slice to drill into the next taxonomic level." button appears to toggle the chart between "by phylum" and "by kingdom". When on the "by phylum" using this, "drill down" incorrectly reported "by kingdom" and broke subsequent "drill down".

Work required

  • Reset any chart or table selections, and map display, when switching between tabs.
  • Only reset the time controls when clicking the time control reset button.
  • Remove the "Click a slice to drill into the next taxonomic level" "toggle" functionality.
  • Fix the charts tab map to correctly apply any defined time filter.
  • Fix the charts tab chart to correctly apply any defined time filter.
  • Change the style of any selected subgroup or species name so that is more clear that that is selected and the map reflects this selection.
  • Fix the time control "play" so that it does not toggle the expand and collapse of the selected group filter (when a group filter is selected). The selected group filter should be in open state and be styled differently from the other group names to indicate that it is the active filter.
  • In the chart and for the item with no rank value, e.g. -kingdom:*, label it so that it does not appear as an error and so it can be clicked. e.g. "unknown".
@adam-collins adam-collins added this to the 4.1.0 milestone Sep 24, 2024
@adam-collins adam-collins self-assigned this Sep 24, 2024
@adam-collins
Copy link
Contributor Author

Might be nothing, but there appears to be a problem with biocache-service's breakdown request today.

  • Works on test.
  • Works with production SOLR.
  • Failed unexpectedly in production biocache-service by returning an empty 200 response. Nothing in the logs indicate an issue.

@adam-collins
Copy link
Contributor Author

Should the chart show "no data", it might be this issue AtlasOfLivingAustralia/biocache-service#926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant