Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capture migration issues #65

Open
adam-collins opened this issue Feb 20, 2024 · 7 comments
Open

capture migration issues #65

adam-collins opened this issue Feb 20, 2024 · 7 comments
Assignees

Comments

@adam-collins
Copy link
Contributor

adam-collins commented Feb 20, 2024

Log of issues found when migrating apps from specieslist-webapp to species-list.

  1. specieslist-webapp does not expose isBIE or isSDS on /ws/speciesList service. Untested fix on branch https://github.com/AtlasOfLivingAustralia/specieslist-webapp/tree/migration-fix

  2. cognito so I can be seen as ADMIN when logged in. Commit a0f8a27

  3. add isBIE search parameter for ala-bie-hub. Commit aa7aeec

  4. cognito so I can send machine to machine JWT. Commit fd7edd0. Makes it work but I am uncertain it is the proper approach. Needs validation and maybe integration into ala-security-project.

  5. fix error when using addSpeciesListItem. Commit 3e3c97d.

  6. addSpeciesListItem appears not to trigger namematching, but for the purpose of bie-index that is OK. Commit 4f1544f

@adam-collins
Copy link
Contributor Author

  1. Unsure of the connection between species-lists and collectory. Does not appear to be a push by species-lists. I'm inferring a need for a script that can remove collectory database entries for species lists. A backup and restore function would be helpful for these entries would also be helpful.

@djtfmartin
Copy link
Member

Ive deliberately omitted the connection between species-lists and collectory - but this should be more widely discussed.

The entries in the collectory that result from a species list being created serve very little purpose, and just result in a rather blank collectory page. I'd favour the BIE indexing lists (authoritative only) instead, and then search results can link straight to the list instead of to a poor in content collectory page. This is an enhancement that come can later.

They also have the affect of skewing stats of data resources. At the time of writing, the homepage for ALA reports:

Screenshot 2024-02-21 at 12 59 57

but of the 4843 data resource, 3562 are species lists, and only 60 of these species lists are authoritative.

cc @peggynewman

@adam-collins
Copy link
Contributor Author

  1. Add isSDS for REST queries and harvest during migration. Commit fbbb0c8. Requires specieslist-webapp 5.1.3-SNAPSHOT for migrate to have access to these fields.

@adam-collins adam-collins self-assigned this Feb 28, 2024
@adam-collins
Copy link
Contributor Author

  1. specieslist-webapp /downloadList generates duplicate column headers, e.g. family, when the default headers also appear in kvpValues. This results in those columns being discarded when migrated into lists. However you cannot upload a list with a column 'family' because it is discarded/ignored. This is not ideal. The primary issue is that sds builds a sensitive-species-data.xml with this uploaded family, not the matched family. I will change sds to use the matched family. This should impact nothing new as it is already an issue if the sds item is not matched in lists.

@adam-collins adam-collins removed their assignment Feb 29, 2024
@adam-collins
Copy link
Contributor Author

adam-collins commented Mar 1, 2024

spatial-hub issues
10. species-lists work required for uploading lists only with taxonID. See #83 Related commit 4f1544f
11. species-lists work required for ingesting, a service with the valid values for mandatory fields. See #82 PR #93

@adam-collins
Copy link
Contributor Author

  1. (update) working to add AuthMachineJwt to the security lib, pull request ala-ws-spring-security treat machine JWT scopes as roles ala-security-project#44. When merged to develop it will need to be included in the branch used by species-lists as well https://github.com/AtlasOfLivingAustralia/ala-security-project/tree/epic/spring_boot3_support/develop. When that is done, AuthMachineJwt.java and AthMachineJwtConfiguration.java can be removed from species-lists.

@jack-brinkman
Copy link
Contributor

jack-brinkman commented Sep 6, 2024

The owner field is never populated during migration, as fullName isn't returned via the legacy lists API - i.e. https://api.ala.org.au/specieslist/ws/speciesList

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants