Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logic on task open to check if locked/completed #523

Closed
cdausmus opened this issue Jul 20, 2022 · 1 comment
Closed

Add logic on task open to check if locked/completed #523

cdausmus opened this issue Jul 20, 2022 · 1 comment
Assignees

Comments

@cdausmus
Copy link
Collaborator

cdausmus commented Jul 20, 2022

Validation possible when task already opened by validator:
A task is able to be validated if a user opens a task that was opened since the page was displayed (and subsequent lock was in place'.

Validate task does not check if the task is locked (i.e. lock is done from the admin list where the link to the task is displayed).

Additionally, add similar logic to transcription/validation to check if it's completed. Stale pages are often left open (wildlifespotter) and users are getting confused when it's read-only and it's completed when they return.

Possible solution in #508. Admin list does not disable validation link even if locked (this is the reason for #508). Check if task is locked in task display (validate) or look further into disabling link.

Expected behaviour: A validator should see a padlock icon on a task when locked by another validator. Additionally, if a validator opens a task for validation that has already been opened by another validator, an error should be displayed stating that that task is currently locked.

@cdausmus cdausmus self-assigned this Jul 20, 2022
@cdausmus cdausmus changed the title Validation possible when task already opened by validator Add logic on task open to check if locked/completed Jul 22, 2022
cdausmus added a commit that referenced this issue Aug 31, 2022
cdausmus added a commit that referenced this issue Aug 31, 2022
@sbearcsiro
Copy link
Contributor

Tested

cdausmus pushed a commit that referenced this issue Oct 27, 2022
DigiVol 6.1.4 Release Notes

- #464 Upgraded Grails version to 3.3.15
- #482 Updated system message to allow closing and remain closed for a browser session
- #534 Fixed issue where grid/list display links in Wildlife Spotter expedition listing were reverting to full expedition listing.
- #535 Fixed issue in Expedition Admin where sorting by task status was not intuitive
- #525 Removed transcription data from forum post view
- #523 Resolved loophole allowing multiple validators to open the same task at the same time

Upgrade issue list

- #543
- #558
- #559
- #561
- #562
- #563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants