Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ManagedService] Allow Broadcaster#broadcast to execute inside a mapped method #1620

Open
jfarcand opened this issue Jun 3, 2014 · 2 comments

Comments

@jfarcand
Copy link
Member

jfarcand commented Jun 3, 2014

A call to Broadcaster.broadcast inside a mapped method will produce recusion if the same method maps again. The following code should work but isn't with 2.1.5+

    @org.atmosphere.config.service.Message(encoders = {JacksonEncoder.class}, decoders = {JacksonDecoder.class})
    public Message onMessage(Message message) throws IOException {
        logger.info("{} just send {}", message.getAuthor(), message.getMessage());


        BroadcasterFactory.getDefault().lookup("/chat").broadcast("{\"message\":\"dsad\",\"author\":\"yoooooooooy\",\"time\":1401825872524}");

        return message;
    }
jfarcand added a commit that referenced this issue Jun 3, 2014
@jfarcand jfarcand reopened this Jun 6, 2014
jfarcand added a commit that referenced this issue Jun 6, 2014
jfarcand added a commit that referenced this issue Jun 6, 2014
@jfarcand jfarcand added 2.3.0 and removed 2.2.0 labels Sep 5, 2014
@jfarcand
Copy link
Member Author

jfarcand commented Sep 5, 2014

Fixed 33c908d

@eugenegoncharuk
Copy link

Guys, any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants