-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compression websocket messages #2482
Comments
@repbl444 can you share a simple test cas on Github? |
I am a newby in atmosphere so maybe I do not understand something. I thought that atmosphere has something to compress messages through websocket , I just should put a flag (true) . By this flag I mean to activate for example some extensions. And JSR356 looked like the one. For me it is necessary to run it on glassfish5(payara5) and I did there some configuration like |
I also add a gzip compression to the application with Spring MVC https://github.com/repbl444/SpringMVCtestCompression |
@repbl444 Salut. I don't have time right now to take a look, but I suspect you need to use Nettosphere if you want to use compression with Atmosphere. I haven't implemented the support for other server. Sorry! I will be happy to integrate your work if you take the Atmosphere code and implement it. |
Got it, thank you |
Can you give me some hints please which classes/configurations needs to be changed in atmosphere to support compression with glassfish? Thanks in advance. |
@repbl444 Just write an AtmosphereInterceptor and check when the transport is websocket, compress it using an open source library. |
Hello, thank you for hints. Now I use atmosphere http streaming instead of websocket with a gzip compression. It needs only a configuration in a server. Glassfish says that it supports the compression when the version of http/1.1 and I have the same Maybe it is a bug or maybe I missed something. Could you give your opinion about that please? |
Hello guys, I am trying to find a solution for compression websocket messages, if you can help, it will be very nice
I want to find a way to compress messages I have in Json formats, cause they are huge,
For investigating I used meteor-chat sample and spring-boot-chat-atmosphere-sample
I found an issue about this with a link https://github.com/Atmosphere/atmosphere/issues/2039/ and did all thing to implement the compression, but as I understand it didn't work. For example, I tried to add some JSR356 support to web.xml in meteor-chat sample or init parameters to the ServletRegistrationBean in spring-boot-sample, changed configuration in domain.xml for payara5(glassfish5) and server.xml in tomcat9 to change settings of the ServletContainer. Tried to do the compression explicitly with the GZipOutputStream but I couldn't get the response from the server in a client side. I tried to add some headers to the response of websocket request like Sec-Websocket-Extensions: permessage-deflate, but in the end I couldn't add this header manually.
The text was updated successfully, but these errors were encountered: