New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Takeoff heading parameter has no effect #50

Open

damien-robotsix opened this issue Jul 26, 2024 · 1 comment

Contributor

damien-robotsix commented Jul 26, 2024

Hello,

Testing the take_off action (void ModeExecutorBase::takeoff). I realized that the heading was not taken into account.

Given my quick investigation, this is due to the handling on PX4 side. It seems to be completely discarded.
https://github.com/PX4/PX4-Autopilot/blob/97561d7802eddb899f1c4f0a3a3ae9aa4c26bb73/src/modules/navigator/navigator_main.cpp#L620

Or maybe I didn't get something but for now I didn't manage to set the yaw during take-off.

No big deal but maybe worth removing the variable since it has no impact.

Collaborator

bkueng commented Jul 30, 2024

Agreed, then let's remove it for now. I just thought it would be nice to have and rather make it work on the PX4 side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment