You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In some circumstances vip-go-ci can note internally that a Pull-Request has an inline comment to a review already submitted to it, when it really does not, but another Pull-Request referring to the same commit-ID has. This can cause vip-go-ci not to publish a PHPCS issue to a review during the execution (for instance), as the logic tries to avoid double-posting the same issue twice. This only affects Pull-Requests that share one or more commits between them.
Replication
Create two Pull-Requests that refer to the same commit-ID with problems that PHPCS should note.
Turn off PHPCS scanning for one of the Pull-Requests, for instance via label that indicates to skip scanning, but not for the other.
Run vip-go-ci for the commit-ID.
See comments being sent to one Pull-Request but not the other, as expected.
Remove label that indicates skip of PHPCS scanning. Run vip-go-ci again for the commit.
Note that review comments are not sent to the Pull-Request that had missing PHPCS comments earlier, although they should by now.
The text was updated successfully, but these errors were encountered:
In some circumstances
vip-go-ci
can note internally that a Pull-Request has an inline comment to a review already submitted to it, when it really does not, but another Pull-Request referring to the same commit-ID has. This can causevip-go-ci
not to publish a PHPCS issue to a review during the execution (for instance), as the logic tries to avoid double-posting the same issue twice. This only affects Pull-Requests that share one or more commits between them.Replication
vip-go-ci
for the commit-ID.vip-go-ci
again for the commit.The text was updated successfully, but these errors were encountered: