Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues noted in PRs that are not there #78

Open
gudmdharalds opened this issue Jan 22, 2020 · 0 comments
Open

Issues noted in PRs that are not there #78

gudmdharalds opened this issue Jan 22, 2020 · 0 comments

Comments

@gudmdharalds
Copy link
Contributor

In some circumstances vip-go-ci can note internally that a Pull-Request has an inline comment to a review already submitted to it, when it really does not, but another Pull-Request referring to the same commit-ID has. This can cause vip-go-ci not to publish a PHPCS issue to a review during the execution (for instance), as the logic tries to avoid double-posting the same issue twice. This only affects Pull-Requests that share one or more commits between them.

Replication

  1. Create two Pull-Requests that refer to the same commit-ID with problems that PHPCS should note.
  2. Turn off PHPCS scanning for one of the Pull-Requests, for instance via label that indicates to skip scanning, but not for the other.
  3. Run vip-go-ci for the commit-ID.
  4. See comments being sent to one Pull-Request but not the other, as expected.
  5. Remove label that indicates skip of PHPCS scanning. Run vip-go-ci again for the commit.
  6. Note that review comments are not sent to the Pull-Request that had missing PHPCS comments earlier, although they should by now.
@gudmdharalds gudmdharalds self-assigned this Jan 23, 2020
@gudmdharalds gudmdharalds removed their assignment Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant