Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON strings appearing in phpunit test output #10470

Open
brettshumaker opened this issue Feb 27, 2025 · 0 comments
Open

JSON strings appearing in phpunit test output #10470

brettshumaker opened this issue Feb 27, 2025 · 0 comments

Comments

@brettshumaker
Copy link
Contributor

Description

There's a particular test that causes a JSON string to be output while running PHPUnit. I think this has been happening for a while but I decided to investigate it today. I've tracked it down to these two switch conditions in test_maybe_handle_onboarding_connect_from_known_from.

Would it be fine to wrap the $wcpay_account->maybe_handle_onboarding(); at the bottom of that test in ob_start() and ob_end_clean() to clean up the PHPUnit output?

Image

cc @dmallory42 @vladolaru as the two folks I see who contributed to that section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant