Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate a Cradle based on .cabal file if cabal version >= 3.4 #42

Open
fendor opened this issue Oct 26, 2021 · 0 comments
Open
Assignees

Comments

@fendor
Copy link
Collaborator

fendor commented Oct 26, 2021

Since haskell/cabal#6622 has been merged, cabal repl works reliably for file paths that are part of a cabal project. Thus, implicit-hie should generate (at least within HLS) only the most basic cabal cradle, and not attempt parsing .cabal file and generate a multi-cradle based on the .cabal file.

This way we reduce the surface for errors in implicit-hie quite considerably. (probably a bit faster too)

For the gen-hie utility, probably nothing should be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants