Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak waveform is truncated #704

Open
terliuk opened this issue Oct 25, 2022 · 0 comments
Open

Peak waveform is truncated #704

terliuk opened this issue Oct 25, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@terliuk
Copy link
Contributor

terliuk commented Oct 25, 2022

Describe the bug

It looks like during peak building the peak waveform is being truncated by at least one sample, resulting in the last peaklet being truncated and ignored. This results in mismatch between data and peak area, as they are computed from peaklets and lone hits separately.

Area is not expected to be affected, while peak timing properties can have a slight effect.

Screenshots
effect on summed area
image
And example of a waveform (zoomed out and zoomed in)
image
image

Versions

I am using current (25 October 2022) development contaner with version
strax : 1.4.0
straxen: 2.0.0

@terliuk terliuk added the bug Something isn't working label Oct 25, 2022
JoranAngevaare pushed a commit that referenced this issue Oct 26, 2022
@JoranAngevaare JoranAngevaare mentioned this issue Oct 26, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant