From 88f2982c0a1530a6be3ce086695a53c53ce0dd1d Mon Sep 17 00:00:00 2001 From: Stephen Garrett Date: Wed, 28 Feb 2024 17:23:06 +0100 Subject: [PATCH] Cleanup TODO functionality in fcgi_stop(). Change-Id: I98191b9811d59ff2bffa7079b0238090fe0320bc --- app/fastcgi_cert_manager.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/app/fastcgi_cert_manager.c b/app/fastcgi_cert_manager.c index 35c739b..afb7e44 100644 --- a/app/fastcgi_cert_manager.c +++ b/app/fastcgi_cert_manager.c @@ -358,13 +358,16 @@ fcgi_stop(void) FCGX_ShutdownPending(); if (g_socket != -1) { - /* TODO: error handling? */ - shutdown(g_socket, SHUT_RD); - g_unlink(g_socket_path); + if (shutdown(g_socket, SHUT_RD) != 0) { + syslog(LOG_WARNING, "Could not shutdown socket, err: %s", strerror(errno)); + } + if (g_unlink(g_socket_path) != 0) { + syslog(LOG_WARNING, "Could not unlink socket, err: %s", strerror(errno)); + } } g_thread_join(g_thread); - /* TODO: closelog() ? */ + closelog(); g_socket_path = NULL; g_socket = -1; g_thread = NULL;