Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inconsistent use of TimeWindow #13

Closed
1 task done
addeeriksson1 opened this issue Dec 1, 2023 · 1 comment · Fixed by #16
Closed
1 task done

[Bug]: Inconsistent use of TimeWindow #13

addeeriksson1 opened this issue Dec 1, 2023 · 1 comment · Fixed by #16
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@addeeriksson1
Copy link

Contact Details

No response

Describe the bug

When calling Parse you can add a TimeWIndow to the options. Currently, this TImeWindow is used both as checking skew for iat and some kind of expiry check on the iat. As a user, these are two separate variables which I want to assign different values for.

It also seems that TimeWindow does not affect the exp of the dpop proof, which seems inconsistent.

Steps to reproduce the behavior

In our case we want to have a smaller clock skew compared to the expiration time. It is also very confusing and hard to debug in the case where exp is set to a value which is a further in the future than iat + TimeWindow.

OS

No response

Relevant log output

No response

Additional Notes

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@addeeriksson1 addeeriksson1 added the bug Something isn't working label Dec 1, 2023
@SalladinBalwer SalladinBalwer added the help wanted Extra attention is needed label Dec 4, 2023
@SalladinBalwer
Copy link
Contributor

I have had a look at this issue and I believe this is due to poor wording in the ParseOptions documentation.

TimeWindow is only used to check for clock skew, it checks that iat is not too far into the future or too far back into the past.

exp is what is used to determine expiration time and should be able to be set further into the future than iat + TimeWindow (probably even recommended).

I think what should be done here is clarifying what TimeWindow is used for.

@SalladinBalwer SalladinBalwer self-assigned this Jan 23, 2024
@SalladinBalwer SalladinBalwer linked a pull request Jan 23, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants