Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring operation name format #46

Open
Sam-Kruglov opened this issue Apr 22, 2020 · 4 comments
Open

Configuring operation name format #46

Sam-Kruglov opened this issue Apr 22, 2020 · 4 comments

Comments

@Sam-Kruglov
Copy link

Sam-Kruglov commented Apr 22, 2020

These guidelines say that it's supposed to be a human-readable string. Why don't we have some spaces? :)

@smcvb
Copy link
Member

smcvb commented Apr 24, 2020

So based on those guidelines, which use underscores, we added underscores.
See the piece you are referencing:

Start a new Span
Required parameters
An operation name, a human-readable string which concisely represents the work done by the Span (for example, an RPC method name, a function name, or the name of a subtask or stage within a larger computation). The operation name should be the most general string that identifies a (statistically) interesting class of Span instances. That is, "get_user" is better than "get_user/314159".

Regardless, I can imagine some configuration options on how operation names are shown. Definitely something to think about, would be a nice inclusion to allow users this capability. Are you up potentially up for contributing such a thing?

Lastly, I feel you are making issues look/feel like "demands". I'd like to ask you to refrain from such phrasing and more so lean towards title names like "Suggestion to adjust operation names" instead. That, in conjunction with adding a clear description with your thoughts and reasoning in polite wording, goes a long way when it comes to our readiness to listen.

@smcvb smcvb changed the title Can Span operation name start with "Send " instead of "send_"? Configuring operation name format Apr 24, 2020
@Sam-Kruglov
Copy link
Author

Sorry, didn't mean to be impolite.

@smcvb
Copy link
Member

smcvb commented Apr 24, 2020

Thanks Sam, glad to hear that. Hope I didn't come over as impolite either.
But, what do you think. Would allowing a form of configuration on the operation names fit your situation?

@Sam-Kruglov
Copy link
Author

Sam-Kruglov commented Apr 24, 2020

Yeah, I could see there being some configuration properties like:

axon.tracing.operation-name-prefix:
  event: 'Publish '
  command: 'Send '
  query: 'Send '

with some defaults set

Sam-Kruglov added a commit to Sam-Kruglov/extension-tracing that referenced this issue Apr 24, 2020
Sam-Kruglov added a commit to Sam-Kruglov/extension-tracing that referenced this issue Apr 24, 2020
@smcvb smcvb added this to the Release 4.4 milestone Apr 28, 2020
@smcvb smcvb removed this from the Release 4.4 milestone Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants