Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address broken support for folding multiple instances #1239

Open
ledwards2225 opened this issue Feb 5, 2025 · 0 comments
Open

Address broken support for folding multiple instances #1239

ledwards2225 opened this issue Feb 5, 2025 · 0 comments

Comments

@ledwards2225
Copy link
Collaborator

We don't support folding multiple instances but there are places in the code where fragments of deprecated support still exist. Aside from making the code more complex there may actually be performance hits. Zac points out one such case where in polynomial folding we do

acc[i] = acc[i] * lagranges[0] + key[i] * lagranges[1]

instead of the equivalent

acc[i] = acc[i] + (key[i] - acc[i]) * gamma

which saves a mul per row per poly. This could be significant given the somewhat inefficient multithreading strategy for poly folding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant