From 96378ae3cc4136d637d8a041c8fb9dbc58b26f86 Mon Sep 17 00:00:00 2001 From: "Ruijie Pei (MSFT)" <49467823+JerryPei1997@users.noreply.github.com> Date: Thu, 30 Apr 2020 11:38:23 +0800 Subject: [PATCH] Update live_test steps and ./resouces (#279) * remove obselete testcase TestGroupsWithAuthFile from resources * Update live_test.yml Co-authored-by: JerryPei1997 <729683758@qq,com> --- .azure-pipelines/steps/live_test.yml | 3 +-- resources/resources_test.go | 19 ------------------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/.azure-pipelines/steps/live_test.yml b/.azure-pipelines/steps/live_test.yml index 9e9f453b9..0ac21c2ea 100644 --- a/.azure-pipelines/steps/live_test.yml +++ b/.azure-pipelines/steps/live_test.yml @@ -14,7 +14,6 @@ steps: displayName: 'Live Test' env: - AZURE_AUTH_LOCATION: $(AZURE_AUTH_LOCATION) AZURE_BASE_GROUP_NAME: $(AZURE_BASE_GROUP_NAME) AZURE_CLIENT_ID: $(AZURE_CLIENT_ID) AZURE_CLIENT_SECRET: $(AZURE_CLIENT_SECRET) @@ -25,4 +24,4 @@ steps: AZURE_USE_DEVICEFLOW: $(AZURE_USE_DEVICEFLOW) AZURE_STORAGE_ACCOUNT_NAME: $(AZURE_STORAGE_ACCOUNT_NAME) AZURE_STORAGE_ACCOUNT_GROUP_NAME: $(AZURE_STORAGE_ACCOUNT_GROUP_NAME) - + \ No newline at end of file diff --git a/resources/resources_test.go b/resources/resources_test.go index 7d3621a2f..b8a67833b 100644 --- a/resources/resources_test.go +++ b/resources/resources_test.go @@ -63,22 +63,3 @@ func TestGroups(t *testing.T) { } t.Logf("created group: %s\n", config.GroupName()) } - -// TODO -- remove or change this test since we are not using the travis CI now -func TestGroupsWithAuthFile(t *testing.T) { - if _, isCi := os.LookupEnv(CiKeyName); isCi == true { - t.Skipf("skipping auth file test in CI") - } - groupName := config.GenerateGroupName("resource-groups-authfile") - config.SetGroupName(groupName) // TODO: don't rely on globals - ctx, cancel := context.WithTimeout(context.Background(), 300*time.Second) - defer cancel() - defer Cleanup(ctx) - - var err error - _, err = CreateGroupWithAuthFile(ctx, config.GroupName()) - if err != nil { - t.Fatalf("failed to create group: %+v", err) - } - t.Logf("created group with auth file: %s\n", config.GroupName()) -}