From 65bf7eaa5f8f7ced3f8081f02dc8a8b7a5ed484e Mon Sep 17 00:00:00 2001 From: teowa <104055472+teowa@users.noreply.github.com> Date: Mon, 27 May 2024 10:41:19 +0000 Subject: [PATCH] hide readonly array --- coverage/coverage.go | 3 +++ coverage/coverage_test.go | 36 +++++++++++++++++++++++++++++++++++- report/pass_report.go | 4 ++++ 3 files changed, 42 insertions(+), 1 deletion(-) diff --git a/coverage/coverage.go b/coverage/coverage.go index 7bf5409..c77b84e 100644 --- a/coverage/coverage.go +++ b/coverage/coverage.go @@ -249,6 +249,9 @@ func (m *Model) CountCoverage() (int, int) { if v.IsReadOnly { continue } + if v.Item != nil && v.Item.IsReadOnly { + continue + } covered, total := v.CountCoverage() m.CoveredCount += covered m.TotalCount += total diff --git a/coverage/coverage_test.go b/coverage/coverage_test.go index 0d0561b..c3bbed3 100644 --- a/coverage/coverage_test.go +++ b/coverage/coverage_test.go @@ -207,7 +207,7 @@ func TestCoverage_DataMigrationServiceTasks(t *testing.T) { name: "DataMigrationServiceTasks", resourceType: "Microsoft.DataMigration/services/serviceTasks@2021-06-30", apiVersion: "2021-06-30", - apiPath: "/subscriptions/fc04246f-04c5-437e-ac5e-206a19e7193f/resourceGroups/DmsSdkRg/providers/Microsoft.DataMigration/services/DmsSdkService/serviceTasks/DmsSdkTask", + apiPath: "/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/DmsSdkRg/providers/Microsoft.DataMigration/services/DmsSdkService/serviceTasks/DmsSdkTask", rawRequest: []string{ `{ "properties": { @@ -226,6 +226,40 @@ func TestCoverage_DataMigrationServiceTasks(t *testing.T) { } } +func TestCoverage_SCVMM(t *testing.T) { + tc := testCase{ + name: "SCVMM", + resourceType: "Microsoft.ScVmm/virtualMachineInstances@2023-10-07", + apiVersion: "2023-10-07", + apiPath: "/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/cli-test-rg-vmm/providers/Microsoft.HybridCompute/machines/test-vm-tf/providers/Microsoft.ScVmm/virtualMachineInstances/default", + rawRequest: []string{ + `{ + "extendedLocation": { + "name": "/subscriptions/12345678-1234-9876-4563-123456789012/resourcegroups/syntheticsscvmmcan/providers/microsoft.extendedlocation/customlocations/terraform-test-cl", + "type": "customLocation" + }, + "properties": { + "infrastructureProfile": { + "cloudId": "/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/cli-test-rg-vmm/providers/Microsoft.SCVMM/Clouds/azcli-test-cloud", + "templateId": "/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/cli-test-rg-vmm/providers/Microsoft.SCVMM/VirtualMachineTemplates/azcli-test-vm-template-win19", + "vmmServerId": "/subscriptions/12345678-1234-9876-4563-123456789012/resourceGroups/SyntheticsSCVMMCan/providers/microsoft.scvmm/vmmservers/tf-test-vmmserver" + } + } +}`, + }, + } + + model, err := testCoverage(t, tc) + if err != nil { + t.Fatalf("process coverage: %+v", err) + } + + expected := 5 + if model.CoveredCount != expected { + t.Fatalf("expected CoveredCount %d, got %d", expected, model.CoveredCount) + } +} + func TestCoverage_DataMigrationTasks(t *testing.T) { tc := testCase{ name: "DataMigrationTasks", diff --git a/report/pass_report.go b/report/pass_report.go index eaba4e4..7e9024c 100644 --- a/report/pass_report.go +++ b/report/pass_report.go @@ -116,6 +116,10 @@ func getReport(model *coverage.Model) []string { continue } + if v.Item != nil && v.Item.IsReadOnly { + continue + } + if v.Variants != nil { variantType := v.ModelName if v.VariantType != nil {